Skip to content

Comments

Update process.info environ to return a Dictionary#1549

Merged
KCarretto merged 2 commits intomainfrom
update-process-info-environ-type-16792017030486866999
Jan 9, 2026
Merged

Update process.info environ to return a Dictionary#1549
KCarretto merged 2 commits intomainfrom
update-process-info-environ-type-16792017030486866999

Conversation

@google-labs-jules
Copy link
Contributor

Updated process.info in eldritch-libprocess to return the environ field as a Dictionary (map of environment variables) instead of a String.
This improves usability by allowing direct access to environment variables like proc["environ"]["PATH"].
Also updated docs/_docs/user-guide/eldritch.md to reflect the API change.


PR created automatically by Jules for task 16792017030486866999 started by @KCarretto

Modified `eldritch-libprocess` `process.info` to return the environment variables as a Dictionary instead of a comma-separated String. This allows easier access to specific environment variables.

Updated the user guide documentation to reflect this change.
@google-labs-jules
Copy link
Contributor Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2026

Summary

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
2938    ±0 2938    ±0 0    ±0 0    ±0 0    ±0 0    ±0 1ms    ±0

Previous Results

Build 🏗️ Result 🧪 Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
#359 2938 2938 0 0 0 0 30.8s

Insights

Average Tests per Run Total Flaky Tests Total Failed Slowest Test (p95)
2938 0 0 54.1s

Slowest Tests

Test 📝 Results 📊 Duration (avg) ⏱️ Duration (p95) ⏱️
eldritch: random::string_impl::tests::test_string_uniform 3 45.0s 54.1s
eldritch: random::string_impl::tests::test_string_uniform 3 45.0s 54.1s
eldritch: random::string_impl::tests::test_string_uniform 3 45.0s 54.1s
eldritch: random::string_impl::tests::test_string_length 3 6.6s 8.8s
eldritch: random::string_impl::tests::test_string_length 3 6.6s 8.8s
eldritch: random::string_impl::tests::test_string_length 3 6.6s 8.8s
eldritch: http::post_impl::tests::test_post_with_params 3 2.8s 8.3s
eldritch: http::post_impl::tests::test_post_with_params 3 2.8s 8.3s
eldritch: http::post_impl::tests::test_post_with_params 3 2.8s 8.3s
eldritch: http::post_impl::tests::test_post_with_params_and_headers 3 2.8s 8.2s

🎉 No failed tests in this run. | 🍂 No flaky tests in this run.

Github Test Reporter by CTRF 💚

🔄 This comment has been updated

Copy link
Collaborator

@nullmonk nullmonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should have it update the tome that looks at the environ

Copy link
Collaborator

@nullmonk nullmonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update tomes using environ

Modified `eldritch-libprocess` `process.info` to return environment variables as a Dictionary instead of a comma-separated String.
Updated `tavern/tomes/process_info/main.eldritch` to handle the new Dictionary format.
Updated `docs/_docs/user-guide/eldritch.md` to reflect the API change.
@KCarretto KCarretto marked this pull request as ready for review January 9, 2026 06:14
@KCarretto KCarretto requested review from hulto and nullmonk January 9, 2026 06:14
Copy link
Collaborator

@nullmonk nullmonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@KCarretto KCarretto added this pull request to the merge queue Jan 9, 2026
Merged via the queue into main with commit 5feffe3 Jan 9, 2026
8 checks passed
@KCarretto KCarretto deleted the update-process-info-environ-type-16792017030486866999 branch January 9, 2026 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants