Skip to content

Fix race condition in TestPortalIntegration #1487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KCarretto merged 2 commits into from
Jan 2, 2026
Merged

Fix race condition in TestPortalIntegration #1487

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fd51e3e
Fix race condition in TestPortalIntegration
google-labs-jules[bot] Jan 2, 2026
1fe5148
Merge branch 'portals' into fix-portal-integration-test-race-65217792…
KCarretto Jan 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions tavern/internal/portals/integration_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,6 +235,21 @@ func TestPortalIntegration(t *testing.T) {
return resp.Mote, nil
})

// Synchronize: Ensure User is fully connected
// We send a ping from User to Agent and verify receipt.
// This ensures that the server's OpenPortal handler has reached sendPortalInput,
// which occurs *after* the subscription to the output topic (PORTAL_OUT) is established.
// This synchronization avoids a race condition where the Agent publishes to PORTAL_OUT
// before the User has subscribed, causing the message to be dropped (as mempubsub warns).
pingData := []byte("ping")
err = userWriter.WriteBytes(pingData, portalpb.BytesPayloadKind_BYTES_PAYLOAD_KIND_DATA)
require.NoError(t, err)

pingMote, err := agentReader.Read()
require.NoError(t, err)
require.Equal(t, pingData, pingMote.GetBytes().Data)
// Note: this consumes User->Agent Seq 0.

// 5. Test Agent -> User (Ordered)
t.Run("AgentToUser_Ordered", func(t *testing.T) {
data := []byte("hello user")
Expand Down