Refactor parser to support error recovery#1436
Conversation
- Added `ExprKind::Error` and `StmtKind::Error` to AST. - Updated `Parser::parse` to return `(Vec<Stmt>, Vec<EldritchError>)`. - Implemented synchronization logic for statement-level recovery. - Implemented recovery logic for list expressions. - Updated `Interpreter` to reject ASTs with errors before execution. - Added `tests/parser_recovery.rs` integration test. - Updated `tests/starlark_parity.rs` to match new parser API. - Exported `ExprKind` and `StmtKind` from `lib.rs`.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
|
Jules run |
Summary
Previous Results
Insights
Slowest Tests
🎉 No failed tests in this run. | 🍂 No flaky tests in this run. Github Test Reporter by CTRF 💚 🔄 This comment has been updated |
Running |
- Added `ExprKind::Error` and `StmtKind::Error` to AST. - Updated `Parser::parse` to return `(Vec<Stmt>, Vec<EldritchError>)`. - Implemented synchronization logic for statement-level recovery. - Implemented recovery logic for list expressions. - Updated `Interpreter` to reject ASTs with errors before execution. - Added `tests/parser_recovery.rs` integration test. - Updated `tests/starlark_parity.rs` to match new parser API. - Exported `ExprKind` and `StmtKind` from `lib.rs`. - Applied `cargo fmt`.
2 participants
This change refactors the Eldritch parser to support error recovery. Instead of failing on the first syntax error, the parser now synchronizes state and continues parsing, collecting errors along the way. This produces a partial AST with placeholder
Errornodes, which is essential for future LSP implementation. The interpreter has been updated to strictly refuse executing any AST that contains parse errors, ensuring safety. A new integration test suite confirms that recovery works as expected for both statements and list elements.PR created automatically by Jules for task 17435696656101769598 started by @KCarretto