Skip to content

Comments

fix(ci): separate historical and current reports in flaky monitor#1424

Merged
KCarretto merged 4 commits intomainfrom
flaky-monitor-fix-14113260139705469870
Dec 27, 2025
Merged

fix(ci): separate historical and current reports in flaky monitor#1424
KCarretto merged 4 commits intomainfrom
flaky-monitor-fix-14113260139705469870

Conversation

@google-labs-jules
Copy link
Contributor

Fixes an issue where historical flaky test reports were being treated as current tests by the ctrf-io/github-test-reporter.

Changes:

  • Modified .github/workflows/flaky-monitor.yml to stop copying historical JSON files into the all-reports directory.
  • Enabled fetch-previous-results: true in the Publish Test Report step to correctly handle historical comparisons using GitHub Artifacts.

PR created automatically by Jules for task 14113260139705469870 started by @KCarretto

Previously, the flaky monitor workflow manually copied historical report files
into the current report directory. This caused the `github-test-reporter` action
to interpret all historical reports as part of the current run, inflating test
counts and preventing proper history comparison.

This change:
- Removes the manual copy of historical files to the report directory.
- Enables `fetch-previous-results: true` to allow the reporter to natively fetch
  artifacts from previous runs for comparison.
@google-labs-jules
Copy link
Contributor Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!


For security, I will only act on instructions from the user who triggered this task.

New to Jules? Learn more at jules.google/docs.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 27, 2025

Summary

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
24996    ±0 24993    ±0 3    ±0 0    ±0 0    ±0 0    ±0 1ms    ±0

Previous Results

Build 🏗️ Result 🧪 Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
#48 24996 24993 3 0 0 0 490791h 50m

Insights

Average Tests per Run Total Flaky Tests Total Failed Slowest Test (p95)
24996 0 3 44.9s

Fail Rate

Fail Rate 0.01%    ±0
Test 📝 Results 📊 Passed ✅ Failed ❌ Fail Rate (%) 📈
TestMuxHistoryOrdering 9 8 1 11.11    ↑11.11
TestMuxHistoryOrdering 9 8 1 11.11    ↑11.11
TestMuxHistoryOrdering 9 8 1 11.11    ↑11.11
TestMuxHistoryOrdering 9 8 1 11.11    ↑11.11
TestMuxHistoryOrdering 9 8 1 11.11    ↑11.11
TestMuxHistoryOrdering 9 8 1 11.11    ↑11.11
TestMuxHistoryOrdering 9 8 1 11.11    ↑11.11
TestMuxHistoryOrdering 9 8 1 11.11    ↑11.11
TestMuxHistoryOrdering 9 8 1 11.11    ↑11.11
eldritch: process::kill_impl::tests::test_process_kill 29 28 1 3.45    ↑3.45
eldritch: process::kill_impl::tests::test_process_kill 29 28 1 3.45    ↑3.45
eldritch: process::kill_impl::tests::test_process_kill 29 28 1 3.45    ↑3.45
eldritch: process::kill_impl::tests::test_process_kill 29 28 1 3.45    ↑3.45
eldritch: process::kill_impl::tests::test_process_kill 29 28 1 3.45    ↑3.45
eldritch: process::kill_impl::tests::test_process_kill 29 28 1 3.45    ↑3.45
eldritch: process::kill_impl::tests::test_process_kill 29 28 1 3.45    ↑3.45
eldritch: process::kill_impl::tests::test_process_kill 29 28 1 3.45    ↑3.45
eldritch: process::kill_impl::tests::test_process_kill 29 28 1 3.45    ↑3.45
eldritch: process::kill_impl::tests::test_process_kill 29 28 1 3.45    ↑3.45
eldritch: process::kill_impl::tests::test_process_kill 29 28 1 3.45    ↑3.45
eldritch: process::kill_impl::tests::test_process_kill 29 28 1 3.45    ↑3.45
eldritch: process::kill_impl::tests::test_process_kill 29 28 1 3.45    ↑3.45
eldritch: process::kill_impl::tests::test_process_kill 29 28 1 3.45    ↑3.45
eldritch: process::kill_impl::tests::test_process_kill 29 28 1 3.45    ↑3.45
eldritch: process::kill_impl::tests::test_process_kill 29 28 1 3.45    ↑3.45
eldritch: process::kill_impl::tests::test_process_kill 29 28 1 3.45    ↑3.45
eldritch: process::kill_impl::tests::test_process_kill 29 28 1 3.45    ↑3.45
eldritch: process::kill_impl::tests::test_process_kill 29 28 1 3.45    ↑3.45
eldritch: process::kill_impl::tests::test_process_kill 29 28 1 3.45    ↑3.45
eldritch: process::kill_impl::tests::test_process_kill 29 28 1 3.45    ↑3.45
eldritch: process::kill_impl::tests::test_process_kill 29 28 1 3.45    ↑3.45
eldritch: process::kill_impl::tests::test_process_kill 29 28 1 3.45    ↑3.45
eldritch: process::kill_impl::tests::test_process_kill 29 28 1 3.45    ↑3.45
eldritch: process::kill_impl::tests::test_process_kill 29 28 1 3.45    ↑3.45
eldritch: process::kill_impl::tests::test_process_kill 29 28 1 3.45    ↑3.45
eldritch: process::kill_impl::tests::test_process_kill 29 28 1 3.45    ↑3.45
eldritch: process::kill_impl::tests::test_process_kill 29 28 1 3.45    ↑3.45
eldritch: process::kill_impl::tests::test_process_kill 29 28 1 3.45    ↑3.45
eldritch: file::moveto_impl::tests::test_moveto_file 30 29 1 3.33    ↑3.33
eldritch: file::moveto_impl::tests::test_moveto_file 30 29 1 3.33    ↑3.33
eldritch: file::moveto_impl::tests::test_moveto_file 30 29 1 3.33    ↑3.33
eldritch: file::moveto_impl::tests::test_moveto_file 30 29 1 3.33    ↑3.33
eldritch: file::moveto_impl::tests::test_moveto_file 30 29 1 3.33    ↑3.33
eldritch: file::moveto_impl::tests::test_moveto_file 30 29 1 3.33    ↑3.33
eldritch: file::moveto_impl::tests::test_moveto_file 30 29 1 3.33    ↑3.33
eldritch: file::moveto_impl::tests::test_moveto_file 30 29 1 3.33    ↑3.33
eldritch: file::moveto_impl::tests::test_moveto_file 30 29 1 3.33    ↑3.33
eldritch: file::moveto_impl::tests::test_moveto_file 30 29 1 3.33    ↑3.33
eldritch: file::moveto_impl::tests::test_moveto_file 30 29 1 3.33    ↑3.33
eldritch: file::moveto_impl::tests::test_moveto_file 30 29 1 3.33    ↑3.33
eldritch: file::moveto_impl::tests::test_moveto_file 30 29 1 3.33    ↑3.33
eldritch: file::moveto_impl::tests::test_moveto_file 30 29 1 3.33    ↑3.33
eldritch: file::moveto_impl::tests::test_moveto_file 30 29 1 3.33    ↑3.33
eldritch: file::moveto_impl::tests::test_moveto_file 30 29 1 3.33    ↑3.33
eldritch: file::moveto_impl::tests::test_moveto_file 30 29 1 3.33    ↑3.33
eldritch: file::moveto_impl::tests::test_moveto_file 30 29 1 3.33    ↑3.33
eldritch: file::moveto_impl::tests::test_moveto_file 30 29 1 3.33    ↑3.33
eldritch: file::moveto_impl::tests::test_moveto_file 30 29 1 3.33    ↑3.33
eldritch: file::moveto_impl::tests::test_moveto_file 30 29 1 3.33    ↑3.33
eldritch: file::moveto_impl::tests::test_moveto_file 30 29 1 3.33    ↑3.33
eldritch: file::moveto_impl::tests::test_moveto_file 30 29 1 3.33    ↑3.33
eldritch: file::moveto_impl::tests::test_moveto_file 30 29 1 3.33    ↑3.33
eldritch: file::moveto_impl::tests::test_moveto_file 30 29 1 3.33    ↑3.33
eldritch: file::moveto_impl::tests::test_moveto_file 30 29 1 3.33    ↑3.33
eldritch: file::moveto_impl::tests::test_moveto_file 30 29 1 3.33    ↑3.33
eldritch: file::moveto_impl::tests::test_moveto_file 30 29 1 3.33    ↑3.33
eldritch: file::moveto_impl::tests::test_moveto_file 30 29 1 3.33    ↑3.33
eldritch: file::moveto_impl::tests::test_moveto_file 30 29 1 3.33    ↑3.33

Failed Tests

Failed Tests
❌ TestMuxHistoryOrdering
=== RUN   TestMuxHistoryOrdering
=== PAUSE TestMuxHistoryOrdering
=== CONT  TestMuxHistoryOrdering
    mux_test.go:214: monitor did not receive message in time
--- FAIL: TestMuxHistoryOrdering (1.25s)

Trace:

No trace available
❌ eldritch: file::moveto_impl::tests::test_moveto_file
Error: Access is denied. (os error 5) at path "C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\.tmppJ2JkY"

Trace:

Error: Access is denied. (os error 5) at path "C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\.tmppJ2JkY"
❌ eldritch: process::kill_impl::tests::test_process_kill
thread 'process::kill_impl::tests::test_process_kill' (506984) panicked at lib/eldritch/src/process/kill_impl.rs:63:21

Trace:

thread 'process::kill_impl::tests::test_process_kill' (506984) panicked at lib/eldritch/src/process/kill_impl.rs:63:21:
assertion `left == right` failed
  left: false
 right: true
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Slowest Tests

Test 📝 Results 📊 Duration (avg) ⏱️ Duration (p95) ⏱️
eldritch: random::string_impl::tests::test_string_uniform 28 39.8s 44.9s
eldritch: random::string_impl::tests::test_string_uniform 28 39.8s 44.9s
eldritch: random::string_impl::tests::test_string_uniform 28 39.8s 44.9s
eldritch: random::string_impl::tests::test_string_uniform 28 39.8s 44.9s
eldritch: random::string_impl::tests::test_string_uniform 28 39.8s 44.9s
eldritch: random::string_impl::tests::test_string_uniform 28 39.8s 44.9s
eldritch: random::string_impl::tests::test_string_uniform 28 39.8s 44.9s
eldritch: random::string_impl::tests::test_string_uniform 28 39.8s 44.9s
eldritch: random::string_impl::tests::test_string_uniform 28 39.8s 44.9s
eldritch: random::string_impl::tests::test_string_uniform 28 39.8s 44.9s

🍂 No flaky tests in this run.

Github Test Reporter by CTRF 💚

🔄 This comment has been updated

Previously, the flaky monitor workflow manually copied historical report files
into the current report directory. This caused the `github-test-reporter` action
to interpret all historical reports as part of the current run, inflating test
counts and preventing proper history comparison.

This change:
- Removes the manual copy of historical files to the report directory.
- Enables `fetch-previous-results: true` to allow the reporter to natively fetch
  artifacts from previous runs for comparison.
- Disables the built-in artifact upload in the reporter to avoid overwriting history.
- Adds a manual step to upload the full history (from the git branch) as the
  artifact `flaky-report`, ensuring subsequent runs have access to the complete
  historical context.
@KCarretto KCarretto marked this pull request as ready for review December 27, 2025 17:51
@KCarretto KCarretto merged commit 9fac2fc into main Dec 27, 2025
6 checks passed
@KCarretto KCarretto deleted the flaky-monitor-fix-14113260139705469870 branch December 27, 2025 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants