Refactor eldritch-libfile to use modular file structure#1423
Merged
Conversation
Splits the monolithic `implants/lib/eldritchv2/stdlib/eldritch-libfile/src/std.rs` file into a `std/` module directory. Each method is now contained in its own `_impl.rs` file (e.g., `append_impl.rs`, `timestomp_impl.rs`) with its associated unit tests. This improves maintainability and navigability of the standard library implementation. Changes: - Created `implants/lib/eldritchv2/stdlib/eldritch-libfile/src/std/` - Created `implants/lib/eldritchv2/stdlib/eldritch-libfile/src/std/mod.rs` - Created 23 `_impl.rs` files for all FileLibrary methods. - Deleted `implants/lib/eldritchv2/stdlib/eldritch-libfile/src/std.rs`
Contributor
Author
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
Contributor
Summary
Previous Results
Insights
Fail Rate
Failed Tests
Slowest Tests
🍂 No flaky tests in this run. Github Test Reporter by CTRF 💚 🔄 This comment has been updated |
Collaborator
|
@jules cargo fmt |
Collaborator
|
Jules run cargo fmt |
Contributor
Author
I have run |
Refactors `implants/lib/eldritchv2/stdlib/eldritch-libfile/src/std.rs` into a `std/` directory with separate implementation files for each method. Runs `cargo fmt` on the implants workspace to ensure code style consistency. - Created `std/mod.rs` and individual `*_impl.rs` files. - Moved logic and tests into respective files. - Applied feature gating (stdlib) consistently across modules.
KCarretto
deleted the
refactor-eldritch-libfile-std-modules-10500821720955141252
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored
eldritch-libfile'sstd.rsinto a directorystd/with separate_impl.rsfiles for each method (e.g.,append_impl.rs,timestomp_impl.rs). This separation includes moving the associated unit tests into their respective files, enhancing code organization and maintainability. Verified functionality with existing tests.PR created automatically by Jules for task 10500821720955141252 started by @KCarretto