Skip to content

Comments

Add winter holiday themed names for December#1406

Merged
KCarretto merged 4 commits intomainfrom
winter-names-4938316588419743715
Dec 25, 2025
Merged

Add winter holiday themed names for December#1406
KCarretto merged 4 commits intomainfrom
winter-names-4938316588419743715

Conversation

@google-labs-jules
Copy link
Contributor

Implemented winter holiday themed name generation for December.
Added noun_winter and adjectives_winter arrays.
Modified getRandomAdjNoun and getRandomAdjAdjNoun to use winter lists in December.
Verified changes with a temporary test case and existing tests.


PR created automatically by Jules for task 4938316588419743715 started by @KCarretto

This change introduces a set of winter and holiday-themed adjectives and nouns to the name generation logic. These names will be used exclusively during the month of December, mirroring the existing functionality for Halloween names.

* Defined `noun_winter` and `adjectives_winter` arrays in `tavern/internal/namegen/namegen.go`.
* Updated `getRandomAdjNoun` and `getRandomAdjAdjNoun` to check for `time.December` and utilize the new word lists.
@google-labs-jules
Copy link
Contributor Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!


For security, I will only act on instructions from the user who triggered this task.

New to Jules? Learn more at jules.google/docs.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 25, 2025

Summary

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
2450    ±0 2450    ±0 0    ±0 0    ±0 0    ±0 0    ±0 26.6s    ↑545ms

Previous Results

Build 🏗️ Result 🧪 Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
#3286 2450 2450 0 0 0 0 26.6s
#3285 2450 2450 0 0 0 0 26.1s
#3283 1879 1877 2 0 0 0 26.1s
#3283 2450 2450 0 0 0 0 26.1s
#3278 2450 2450 0 0 0 0 26.4s

Insights

Average Tests per Run Total Flaky Tests Total Failed Slowest Test (p95)
2336 0 2 44.2s

Fail Rate

Fail Rate 0.02%    ↓0.01
Test 📝 Results 📊 Passed ✅ Failed ❌ Fail Rate (%) 📈
eldritch: pivot::ssh_exec_impl::tests::test_pivot_ssh_exec 15 14 1 6.67    ↓1.66
eldritch: pivot::ssh_copy_impl::tests::test_pivot_ssh_copy 15 14 1 6.67    ↓1.66
eldritch: pivot::ssh_copy_impl::tests::test_pivot_ssh_copy 15 14 1 6.67    ↓1.66
eldritch: pivot::ssh_exec_impl::tests::test_pivot_ssh_exec 15 14 1 6.67    ↓1.66
eldritch: pivot::ssh_copy_impl::tests::test_pivot_ssh_copy 15 14 1 6.67    ↓1.66
eldritch: pivot::ssh_exec_impl::tests::test_pivot_ssh_exec 15 14 1 6.67    ↓1.66

Failed Tests

No failed tests ✨

Slowest Tests

Test 📝 Results 📊 Duration (avg) ⏱️ Duration (p95) ⏱️
eldritch: random::string_impl::tests::test_string_uniform 14 39.1s 44.2s
eldritch: random::string_impl::tests::test_string_uniform 14 39.1s 44.2s
eldritch: random::string_impl::tests::test_string_uniform 14 39.1s 44.2s
eldritch: process::info_impl::tests::test_info_default 15 2.0s 9.3s
eldritch: process::info_impl::tests::test_info_default 15 2.0s 9.3s
eldritch: process::info_impl::tests::test_info_default 15 2.0s 9.3s
eldritch: pivot::port_scan_impl::tests::test_portscan_return_type_starlark_dict_from_interpreter 15 1.9s 8.7s
eldritch: pivot::port_scan_impl::tests::test_portscan_return_type_starlark_dict_from_interpreter 15 1.9s 8.7s
eldritch: pivot::port_scan_impl::tests::test_portscan_return_type_starlark_dict_from_interpreter 15 1.9s 8.7s
eldritch: pivot::ssh_copy_impl::tests::test_pivot_ssh_copy 15 3.2s 8.6s

🍂 No flaky tests detected across all runs. | ⏱️ Measured over 5 runs.

Github Test Reporter by CTRF 💚

🔄 This comment has been updated

@KCarretto KCarretto marked this pull request as ready for review December 25, 2025 18:49
hulto
hulto previously approved these changes Dec 25, 2025
"merry",
"nippy",
"polar",
"raw",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jules change this to something else

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replaced "raw" with "radiant" as requested.

"sparkling",
"spirited",
"stormy",
"white",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change this one too

Addresses PR feedback to replace the adjective "raw" with "radiant" in the winter-themed name generation list.
google-labs-jules bot and others added 2 commits December 25, 2025 20:39
Updates the winter holiday name generation with a larger, warmer, and cozier list of nouns and adjectives.
- Removed "white" as requested.
- Added words like "snug", "cozy", "warm", "cuddly", "fuzzy", etc.
- Significantly increased the size of both lists to ensure better uniqueness.
@KCarretto KCarretto merged commit d2f81bd into main Dec 25, 2025
6 checks passed
@KCarretto KCarretto deleted the winter-names-4938316588419743715 branch December 25, 2025 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants