Golemv2 by nullmonk · Pull Request #1390 · spellshift/realm

nullmonk · 2025-12-24T05:28:24Z

What type of PR is this?

/kind feature

What this PR does / why we need it:

Add Golemv2 for use with eldritchv2

implants/golemv2/Cargo.toml

implants/golemv2/src/agent.rs

implants/golemv2/src/main.rs

nullmonk · 2025-12-24T05:49:29Z

This test fails bc the FakeLibrary doesnt actually execute the command. Should I update the test to just check that the eldritch is evaluating or update the FakeLib to run commands?

Link to the problem line:

realm/implants/lib/eldritchv2/stdlib/eldritch-libsys/src/fake.rs

Line 104 in 5b2a795

map.insert("stdout".into(), Value::String(format!("Executed: {}", cmd)));

KCarretto · 2025-12-24T18:25:20Z

This test fails bc the FakeLibrary doesnt actually execute the command. Should I update the test to just check that the eldritch is evaluating or update the FakeLib to run commands?
Link to the problem line:

realm/implants/lib/eldritchv2/stdlib/eldritch-libsys/src/fake.rs

Line 104 in 5b2a795

map.insert("stdout".into(), Value::String(format!("Executed: {}", cmd)));

I would update the test with the info that the command will not actually be executed.

KCarretto

Fix tests and then lgtm. Be sure the regular assets lib still works with imixv2

implants/golem/tests/cli.rs

implants/golemv2/Cargo.toml

implants/golemv2/src/main.rs

github-actions · 2025-12-24T20:20:34Z

Summary

Tests 📝	Passed ✅	Failed ❌	Skipped ⏭️	Other ❓	Flaky 🍂	Duration ⏱️
2959 ±0	2959 ±0	0 ±0	0 ±0	0 ±0	0 ±0	1ms ±0

Previous Results

Build 🏗️	Result 🧪	Tests 📝	Passed ✅	Failed ❌	Skipped ⏭️	Other ❓	Flaky 🍂	Duration ⏱️
#365	✅	2959	2959	0	0	0	0	29.4s

Insights

Average Tests per Run	Total Flaky Tests	Total Failed	Slowest Test (p95)
2959	0	0	46.4s

Slowest Tests

Test 📝	Results 📊	Duration (avg) ⏱️	Duration (p95) ⏱️
eldritch: random::string_impl::tests::test_string_uniform	3	43.0s	46.4s
eldritch: random::string_impl::tests::test_string_uniform	3	43.0s	46.4s
eldritch: random::string_impl::tests::test_string_uniform	3	43.0s	46.4s
eldritch: pivot::port_scan_impl::tests::test_portscan_return_type_starlark_dict_from_interpreter	3	2.7s	8.1s
eldritch: pivot::port_scan_impl::tests::test_portscan_return_type_starlark_dict_from_interpreter	3	2.7s	8.1s
eldritch: pivot::port_scan_impl::tests::test_portscan_return_type_starlark_dict_from_interpreter	3	2.7s	8.1s
eldritch: pivot::ssh_copy_impl::tests::test_pivot_ssh_copy	3	4.0s	8.0s
eldritch: pivot::ssh_copy_impl::tests::test_pivot_ssh_copy	3	4.0s	8.0s
eldritch: pivot::ssh_copy_impl::tests::test_pivot_ssh_copy	3	4.0s	8.0s
eldritch: process::info_impl::tests::test_info_default	3	2.8s	8.0s

_{🎉 No failed tests in this run. | 🍂 No flaky tests in this run.}

Github Test Reporter by CTRF 💚

🔄 This comment has been updated

KCarretto · 2026-01-09T06:18:47Z

implants/golemv2/src/directorybackend.rs

+use alloc::vec::Vec;
+use anyhow::anyhow;
+use core::fmt::Debug;
+use eldritch_libassets::std::AssetBackend;


We should re-export this in eldritchv2 instead of requiring callers to import specific standard libraries on top of eldritchv2

KCarretto · 2026-01-09T06:19:22Z

implants/golemv2/src/directorybackend.rs

+use std::fs;
+use std::path::PathBuf;
+
+const MAX_RECURSION_DEPTH: usize = 10;


We can probably safely make this higher?

KCarretto · 2026-01-09T06:20:47Z

implants/golemv2/src/repl.rs

+use std::io::{self, Write};
+use std::time::Duration;
+
+pub fn repl(mut inter: Interpreter) -> io::Result<()> {


We should definitely move this to the repl crate since it's used by 3+ clients now

can we do that in a separate PR?

hulto

LGTM 😎

hulto reviewed Dec 24, 2025

View reviewed changes

implants/golemv2/Cargo.toml Outdated Show resolved Hide resolved

implants/golemv2/src/agent.rs Outdated Show resolved Hide resolved

implants/golemv2/src/agent.rs Outdated Show resolved Hide resolved

implants/golemv2/src/main.rs Outdated Show resolved Hide resolved

KCarretto self-requested a review December 24, 2025 17:41

KCarretto requested changes Dec 24, 2025

View reviewed changes

nullmonk force-pushed the golemv2 branch 2 times, most recently from 9067368 to 654f9e3 Compare January 7, 2026 21:41

nullmonk added 10 commits January 7, 2026 16:45

Add asset backend, fix imix to use them

a60b661

Add golem v2

43e0aa7

cargo fmt

99435f9

FIx test and cleanup a filename

82f540f

fix, deps, remove the agent for FakeAgent

550811b

cleanup warning in test file

47dcdf8

Format issue

735dae3

Clean up Kyles nits

1e5466b

Add empty input params for the tomes

07b283d

Update to support changes in main

883961f

nullmonk force-pushed the golemv2 branch from 654f9e3 to 883961f Compare January 7, 2026 21:46

nullmonk added 6 commits January 7, 2026 17:09

Fix to support the split of impls

1671f0a

windows newlines

318529a

more windows strings

967f524

Clean up tests

72582db

cargo fmt

179e43b

fix tests in mock environment

4709fdd

KCarretto previously approved these changes Jan 9, 2026

View reviewed changes

Export changes

bbb7bea

nullmonk dismissed KCarretto’s stale review via bbb7bea January 9, 2026 06:54

fix import

1aa61f4

nullmonk enabled auto-merge January 9, 2026 07:51

hulto approved these changes Jan 9, 2026

View reviewed changes

nullmonk added this pull request to the merge queue Jan 9, 2026

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 9, 2026

nullmonk added this pull request to the merge queue Jan 9, 2026

Merged via the queue into main with commit b4f26df Jan 10, 2026
12 of 13 checks passed

nullmonk deleted the golemv2 branch January 10, 2026 00:12

Comments

Conversation

nullmonk commented Dec 24, 2025

What type of PR is this?

What this PR does / why we need it:

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nullmonk commented Dec 24, 2025

Uh oh!

KCarretto commented Dec 24, 2025

Uh oh!

KCarretto left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Dec 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Previous Results

Insights

Slowest Tests

Uh oh!

KCarretto Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

KCarretto Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

KCarretto Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

nullmonk Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

hulto left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions bot commented Dec 24, 2025 •

edited

Loading