Skip to content

Comments

Automated Flaky Test Fixes#1381

Merged
KCarretto merged 3 commits intomainfrom
fix/flaky-tests-9220691846525250458
Dec 24, 2025
Merged

Automated Flaky Test Fixes#1381
KCarretto merged 3 commits intomainfrom
fix/flaky-tests-9220691846525250458

Conversation

@google-labs-jules
Copy link
Contributor

Identified and fixed flaky tests in the Go backend.

  • Replaced hardcoded Pub/Sub topic names with unique names to prevent state leakage between test runs in tavern/internal/http/stream.
  • Replaced time.Sleep with polling in tavern/internal/redirectors/grpc to robustly wait for server startup.
  • Removed unnecessary sleep in mux_test.go.

PR created automatically by Jules for task 9220691846525250458 started by @KCarretto

- Use unique topic names in mempubsub tests
- Replace sleep with polling in gRPC redirector tests
- Remove unnecessary sleeps
@google-labs-jules
Copy link
Contributor Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!


For security, I will only act on instructions from the user who triggered this task.

New to Jules? Learn more at jules.google/docs.

@KCarretto KCarretto marked this pull request as ready for review December 23, 2025 22:28
@KCarretto KCarretto requested a review from hulto December 23, 2025 22:28
- Use unique topic names in mempubsub tests
- Replace sleep with polling in gRPC redirector tests
- Remove unnecessary sleeps
- Run cargo fmt and go fmt
@KCarretto KCarretto requested a review from Cictrone December 24, 2025 00:15
Copy link
Collaborator

@hulto hulto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems godo to me

@KCarretto KCarretto merged commit e968827 into main Dec 24, 2025
5 checks passed
@KCarretto KCarretto deleted the fix/flaky-tests-9220691846525250458 branch December 24, 2025 04:01
nullmonk pushed a commit that referenced this pull request Dec 24, 2025
* Fix flaky tests in Tavern backend

- Use unique topic names in mempubsub tests
- Replace sleep with polling in gRPC redirector tests
- Remove unnecessary sleeps

* Fix flaky tests in Tavern backend and format code

- Use unique topic names in mempubsub tests
- Replace sleep with polling in gRPC redirector tests
- Remove unnecessary sleeps
- Run cargo fmt and go fmt

---------

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
Co-authored-by: KCarretto <Kcarretto@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants