1212 feature automate pubkey based on callback uri#1214
Merged
Conversation
KCarretto
reviewed
Dec 9, 2025
| }; | ||
|
|
||
| // Set the IMIX_SERVER_PUBKEY environment variable for the build | ||
| println!("cargo:rustc-env=IMIX_SERVER_PUBKEY={}", pubkey); |
Collaborator
There was a problem hiding this comment.
How does it deal with formatting? I think it's preferrable to use an API like std::env::var to ensure this gets set to an env var instead of string formatting into something that looks like a CLI arg, otherwise feels like this could be a vector for command injection
Collaborator
Author
There was a problem hiding this comment.
This is the idiomatic way rust suggests passing env vars from build.rs.
KCarretto
approved these changes
Dec 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Make getting started easier allowing a one command setup.
Which issue(s) this PR fixes:
Fixes #1212