Skip to content

Comments

Fix dropAllData foreign key constraint error#1151

Merged
KCarretto merged 1 commit intomainfrom
fix-dropalldata-constraint
Dec 6, 2025
Merged

Fix dropAllData foreign key constraint error#1151
KCarretto merged 1 commit intomainfrom
fix-dropalldata-constraint

Conversation

@google-labs-jules
Copy link
Contributor

This PR fixes a foreign key constraint violation that occurred when running the dropAllData mutation. The issue was that Beacon entities were being deleted while Shell entities (which reference them) still existed. The fix involves deleting Shell entities before Beacon entities. A new test case ReproConstraintError.yml has been added to tavern/internal/graphql/testdata/mutations/dropAllData to verify the fix.


PR created automatically by Jules for task 10742513871889860316 started by @KCarretto

Explicitly delete Shell entities before deleting Beacons in the dropAllData mutation resolver.
Shells have a foreign key reference to Beacons, causing deletion failure when Beacons are deleted first.
Added a reproduction test case to verify the fix.
@google-labs-jules
Copy link
Contributor Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!


For security, I will only act on instructions from the user who triggered this task.

New to Jules? Learn more at jules.google/docs.

@KCarretto KCarretto marked this pull request as ready for review December 6, 2025 15:43
Copy link
Collaborator

@hulto hulto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YOLO

@chatgpt-codex-connector
Copy link

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@KCarretto KCarretto merged commit b1c8696 into main Dec 6, 2025
5 checks passed
@KCarretto KCarretto deleted the fix-dropalldata-constraint branch December 6, 2025 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants