-
Notifications
You must be signed in to change notification settings - Fork 2
Fixing BFIC INF values. #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…. Now BFIC values no longer go to INF.
|
Dr. Speegle, I also have another question about the probability vector plot. Is it supposed to have massive numbers on the Y-Axis? Is this something that I should try to mess with to make it more readable or is this how it should be? If there are any other bugs you would like me to take a look at, I would be happy to since I am running out of things to do! |
# Conflicts: # R/SVDetectChangePoint.R
|
So I had some major confusion/headaches with git when trying to create my new file for the SV function. It kept providing the error "Error: 'SVDetectChangePoint' is not an exported object from 'namespace:cpbaywave'" Which strangely enough I did not have when creating the plotting function. I then thought, okay maybe I will delete it and start over, but that was a naïve because I became even more confused. I am going to instead focus on laying out the structure of the function and then solve these git issues later. Sorry for the mess! |
|
No worries, maybe we should schedule a time to discuss if you don't figure it out in the next day or two?
…________________________________________
Van: thofstrand ***@***.***>
Gestuur: Maandag 18 Julie 2022 14:58
aan: speegled/cpbaywave
Aa: Subscribed
onderwerp: [External] Re: [speegled/cpbaywave] Fixing BFIC INF values. (PR #11)
So I had some major confusion/headaches with git when trying to create my new file for the SV function. It kept providing the error "Error: 'SVDetectChangePoint' is not an exported object from 'namespace:cpbaywave'" Which strangely enough I did not have when creating the plotting function. I then thought, okay maybe I will delete it and start over, but that was a naïve because I became even more confused. I am going to instead focus on laying out the structure of the function and then solve these git issues later. Sorry for the mess!
—
Reply to this email directly, view it on GitHub<https://urldefense.com/v3/__https://github.com/speegled/cpbaywave/pull/11*issuecomment-1188240770__;Iw!!K543PA!MDQSJZtmLeuOi0ByyMuLDMdfeJdhl7zpKsmy9fU140MCA4Jqi1ZZqDARYgIG-Np95xoLnMUXV26oIL1P_aRM0q2x$>, or unsubscribe<https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AD7OYNDP7COKD5NBAT3UDATVUWZNJANCNFSM53P7PL2Q__;!!K543PA!MDQSJZtmLeuOi0ByyMuLDMdfeJdhl7zpKsmy9fU140MCA4Jqi1ZZqDARYgIG-Np95xoLnMUXV26oIL1P_ZI367I3$>.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
|
Yes that would be great! I am free any day this week! |
…itted, so that's why there are so many files. Added SVDetectChangePoint
Changed t1 to use
lgamma()and made M1 no longer take the log of t1 now BFIC values no longer go to INF.