-
Notifications
You must be signed in to change notification settings - Fork 1
Add security configurations and authentication environment variables … #104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…to Docker Compose files - Add N8N_BLOCK_ENV_ACCESS_IN_NODE=true to docker-compose.yml for enhanced security - Add N8N_ENV_ACCESS_ALLOWED with ASSEMBLY_USER and ASSEMBLY_PASS to docker-compose.prod.yml - Add ASSEMBLY_USER and ASSEMBLY_PASS environment variables to both compose files
WalkthroughUpdates the n8n service environment in docker-compose.yml and docker-compose.prod.yml. Adds SEMBLY_USER and SEMBLY_PASS variables (defaults in dev; required in prod) and configures environment access policies (block in dev; allowlist in prod). No other services or settings are changed. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🔍 Vulnerabilities of
|
| digest | sha256:1d8bb517b3f3c90572cecd0dfbceaee7c023d035b93a91fb4d5e308aa49675d7 |
| vulnerabilities | |
| platform | linux/amd64 |
| size | 218 MB |
| packages | 358 |
📦 Base Image alpine:3
| also known as |
|
| digest | sha256:1c4eef651f65e2f7daee7ee785882ac164b02b78fb74503052a26dc061c90474 |
| vulnerabilities |
Description
| ||||||||||||
Description
| ||||||||||||
Description
| ||||||||||||
Description
| ||||||||||||
Description
| ||||||||||||
Description
| ||||||||||||
Description
| ||||||||||||
Description
| ||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (2)
docker-compose.yml (1)
31-34: Optional: Consider mirroring the explicit block setting in prod for clarity.Prod relies on the default for N8N_BLOCK_ENV_ACCESS_IN_NODE. Setting it explicitly in prod avoids ambiguity and future regressions.
Proposed addition in docker-compose.prod.yml n8n env:
+ - N8N_BLOCK_ENV_ACCESS_IN_NODE=truedocker-compose.prod.yml (1)
25-28: Security: Consider Docker secrets for credentials.Environment variables are fine, but for stronger posture in prod, prefer Docker secrets or external secret managers; then reference via files.
If you stay with env vars, ensure these aren’t logged or exported in diagnostics.
📜 Review details
Configuration used: Path: .coderabbit.yml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
docker-compose.prod.yml(1 hunks)docker-compose.yml(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
docker-compose.yml
📄 CodeRabbit inference engine (.cursor/rules/docker-configuration.mdc)
docker-compose.yml: All service configurations, including service dependencies, volume mounts, network configuration, environment variables, and port mappings, must be defined in docker-compose.yml
Services must communicate over an internal Docker network with only the specified ports exposed: n8n (5678), Temporal (7233), Temporal UI (8080), PostgreSQL (5432), and OpenSearch (9200)The repository must include a docker-compose.yml file as the main service orchestration configuration.
Use docker compose up -d to start all services
Files:
docker-compose.yml
🧠 Learnings (1)
📚 Learning: 2025-07-28T16:44:24.081Z
Learnt from: CR
PR: speedandfunction/automatization#0
File: .cursor/rules/docker-configuration.mdc:0-0
Timestamp: 2025-07-28T16:44:24.081Z
Learning: Applies to docker-compose.yml : Services must communicate over an internal Docker network with only the specified ports exposed: n8n (5678), Temporal (7233), Temporal UI (8080), PostgreSQL (5432), and OpenSearch (9200)
Applied to files:
docker-compose.prod.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Docker Security Scanning (n8n, Dockerfile.n8n, n8n-test:latest)
- GitHub Check: Service Availability Check
🔇 Additional comments (1)
docker-compose.yml (1)
31-34: Incorrect — repo already uses SEMBLY_USER/SEMBLY_PASS; do not apply ASSEMBLY_ rename*Search found SEMBLY_USER/SEMBLY_PASS in docker-compose.yml (lines 33–34) and docker-compose.prod.yml (lines 26–28); N8N_ENV_ACCESS_ALLOWED also references SEMBLY_. Applying the proposed ASSEMBLY_ diff would introduce mismatches — either rename every occurrence (including the allowlist) or keep SEMBLY_*.
Likely an incorrect or invalid review comment.
|
|
Resolving my previous comment - SEMBLY_* naming is correct as clarified by the author. |



…to Docker Compose files
Summary by CodeRabbit