cli: fix some config options not taken into account when set in a con…#123
Merged
cli: fix some config options not taken into account when set in a con…#123
Conversation
…fig file `speaker_diarization_config` and `topic_detection_config` could be set individually from dedicated cli options but not from config file passed via --config option.
clairesc
force-pushed
the
fix-config-options-from-file
branch
from
937bc6c to
aeb9e63
Compare
dumitrugutu
approved these changes
May 15, 2025
Contributor
dumitrugutu
left a comment
dumitrugutu
left a comment
There was a problem hiding this comment.
Thanks for fixing this. Can you add some tests?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
speaker_diarization_configandtopic_detection_configcould be set individually from dedicated cli options but not from config file passed via--configoption.