-
-
Notifications
You must be signed in to change notification settings - Fork 595
Fix resizing of Live views with reduced size. #1840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
move all code to LiveRenderable and pass RenderOptions instead
@microsoft-github-policy-service agree company="Intronik" |
@belucha I tested your changes in steam-lancache-prefill and they work as expected. Thanks for the good work! |
Co-authored-by: Patrik Svensson <patriksvensson@users.noreply.github.com>
Co-authored-by: Patrik Svensson <patriksvensson@users.noreply.github.com>
Co-authored-by: Patrik Svensson <patriksvensson@users.noreply.github.com>
Merged! Thank you for your contribution. Much appreciated! 👍 |
I also tried an approach where LiveRenderable did not have PositionCursor and RestoreCursor methods, nor caching it's shape, but the LiveDisplayRenderer - Hook was using DECSC() and DECRC() Ansi sequences to store/restore the cursor positions. But I do not know if that is available on all platforms and thought that would be a too large change, from the working solution. I admire the work done with SpectreConsole ... gives me great joy, building console applications now! Regards |
#703
When resizing Live views e.g. tables this was working only when the size increased. This patch fixes that by detecting size decreases and forcing the IRenderable to forget it's old shape.
fixes #703
Changes
Please upvote 👍 this pull request if you are interested in it.