Lara dsl deprecation #4
Conversation
…aths in settings.gradle files
There was a problem hiding this comment.
Pull Request Overview
This PR implements a "Lara DSL deprecation" update to the AnyWeaver project, modernizing the codebase by migrating from deprecated LARA DSL patterns to newer framework approaches and updating dependencies.
- Removes deprecated LARA DSL components and test infrastructure
- Modernizes JavaScript module imports and test patterns
- Updates build configuration and dependency management
Reviewed Changes
Copilot reviewed 38 out of 38 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| AnyWeaverSpecs/ | Completely removed deprecated weaver specifications module |
| AnyWeaver/test/ | Removed legacy Java-based test infrastructure |
| AnyWeaver/src/pt/up/fe/specs/anycompiler/weaver/ | Streamlined weaver classes by removing deprecated DSL methods and updated array handling |
| AnyWeaver/test-resources/ | Updated test files to use modern ES module imports instead of deprecated laraImport |
| AnyWeaver-JS/ | Added modern TypeScript-based test infrastructure with Jest configuration |
| AnyAst/src/ | Replaced SpecsCheck utility calls with standard Objects.requireNonNull and updated method names |
| Build files | Updated Gradle configurations, dependency versions, and CI/CD workflows |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
| with: | ||
| repository: specs-feup/specs-java-libs | ||
| path: specs-java-libs | ||
| # This is causing problems in PRs, for now it will always be the default branch | ||
| #ref: ${{ steps.Branch-specs-java-libs.outputs.value == '1' && env.BRANCH_NAME || env.DEFAULT_BRANCH }} | ||
| ref: ${{ steps.Branch-specs-java-libs.outputs.value == '1' && env.BRANCH_NAME || env.DEFAULT_BRANCH }} |
There was a problem hiding this comment.
[P1] Use actual default branch when external branch is missing
When the nightly workflow checks out lara-framework and specs-java-libs it now falls back to env.DEFAULT_BRANCH when the feature branch does not exist. DEFAULT_BRANCH is defined earlier as ${{ github.base_ref || 'staging' }}, but neither of these external repositories has a staging branch. A push to main (where BRANCH_NAME is main and branch-exists-* is 0) will therefore attempt ref: staging and the checkout will fail with fatal: Remote branch staging not found. The previous workflow handled this by checking out master (the actual default) when the branch was missing. This change will break the Java build job for main and release branches until the fallback targets a branch that exists in each upstream repository.
Useful? React with 👍 / 👎.
No description provided.