Jrm/optimise query #3677
Merged
Jrm/optimise query #3677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gjedlicska
approved these changes
Jan 17, 2025
JR-Morgan
added a commit
that referenced
this pull request
Feb 4, 2025
* fix(navis): Fixes missing element properties on coalesce from First Selected object. (#3651) * Correct access for const * Corrected NullParam exception signature * LINQ logic made logical * corrected correction * indent all the things * minor(navis): coalesced properties to reflect instance as dominant on duplicate (#3652) * Correct access for const * Corrected NullParam exception signature * LINQ logic made logical * corrected correction * indent all the things * First becomes Last * Limit FE1 API usage to essentials (#3662) * Updated DUI2 * remove comment subscription * Comments * fix comment * VersionUpdate subscription workaround * Dynamo * Fixed issue with collections being modified while enumerating * removed deprecated tests * Marked deprecated true on all legacy subscriptions * using directives * CNX-961 - Remove keyboard shortcuts from plugin registration (#3667) Remove keyboard shortcuts from plugin registration * fix(Revit): DirectShape Instances to Speckle Conversion support (#3572) For POC purposes - implements a fix - needs investigation * Jrm/ci fix (#3670) * Ensure CI runs on net8 * remove net 7 * bump csharpier for net8 support * ensure net8 sdk is available on connector builds * relax rollforward rules instead * Fixed email invites (#3669) * removed chunking from model class. (#3668) Co-authored-by: Jedd Morgan <45512892+JR-Morgan@users.noreply.github.com> * CNX-619 Revit Analytical Panel (#3645) * File Added: ConvertStructuralMaterial Separated methods pertaining to StructuralMaterial outside of the ConvertAnalyticalStick.cs file. Didn't make sense that these functions were in the ConvertAnalyticalStick.cs when the ConvertAnalyticalSurface.cs referenced them * ScaleToSpeckle Material properties were sent as revit internal units. Inconsistent with the Revit model / project units. These can't be used for connection applications (e.g. receiving analytical elements in ETABS) * ETABS Receive Property2D ETABS currently only created properties for Element2Ds with a CSIProperty2D, but what about Property2D? These should also be received without us defaulting to the "Slab1" ETABS section. * ETABS Receive Wall Property Walls were previously assigned with slab sections which is incorrect. The WallPropertyToNative() was implemented (previously raised a ConversionNotSupportedException for some reason) * RVT 22 Scaling Updates Testing on Revit 2022 - ETABS connection * Default Fallback Assign at least something to Element2D * Fixed shared project case sensitivity * IDE0005 --------- Co-authored-by: Jedd Morgan <45512892+JR-Morgan@users.noreply.github.com> * Revert deploy step to use .NET 6 SDK for Manager Feed (#3671) * Fix ping in SDK and add user agent headers (#3672) * ping should ping a static asset and add user agent headers * fix: fmt * Removed frontend headers check for FE1 servers * Removed another test that relied on this pinging --------- Co-authored-by: Dimitrie Stefanescu <didimitrie@gmail.com> Co-authored-by: Jedd Morgan <45512892+JR-Morgan@users.noreply.github.com> * Remove Node Run events from GH nodes (#3674) Removed tracking for grasshopper node runs * Ping `/api/ping` with fallbacks to older style pings (#3676) * Multi-ping * tests * adjusted timeouts * Removed favourite stream count from DUI2 stream view (#3675) * Jrm/optimise query (#3677) * Optimised large queries * fix mistake * Jrm/optimise query (#3678) * Optimised large queries * fix mistake * fix another mistake * fix: Disappearing Grasshopper components after save (#3679) * fix: Dissapearing components after save SyncReceive would disappear upon opening a document (or while saving) due to exceptions being thrown in the Read/Write logic, which shouldn't ever throw. * fix: Write method for Kit name is unnecessary, dealt with in parent class * fix(gh): Use external getter for `Value` property (#3680) Do not assume internal storage `m_value` will exist in all GH_Goo's, some have varying implementation, but `Value` is usually consistent on all pre-rhino8 GH types --------- Co-authored-by: Alan Rynne <alan@speckle.systems> Co-authored-by: Jonathon Broughton <760691+jsdbroughton@users.noreply.github.com> Co-authored-by: Mucahit Bilal GOKER <51519350+bimgeek@users.noreply.github.com> Co-authored-by: Björn Steinhagen <steinhagen.bjoern@gmail.com> Co-authored-by: Adam Hathcock <adamhathcock@users.noreply.github.com> Co-authored-by: Dimitrie Stefanescu <didimitrie@gmail.com>
JR-Morgan
added a commit
that referenced
this pull request
Feb 5, 2025
* fix(navis): Fixes missing element properties on coalesce from First Selected object. (#3651) * Correct access for const * Corrected NullParam exception signature * LINQ logic made logical * corrected correction * indent all the things * minor(navis): coalesced properties to reflect instance as dominant on duplicate (#3652) * Correct access for const * Corrected NullParam exception signature * LINQ logic made logical * corrected correction * indent all the things * First becomes Last * Limit FE1 API usage to essentials (#3662) * Updated DUI2 * remove comment subscription * Comments * fix comment * VersionUpdate subscription workaround * Dynamo * Fixed issue with collections being modified while enumerating * removed deprecated tests * Marked deprecated true on all legacy subscriptions * using directives * CNX-961 - Remove keyboard shortcuts from plugin registration (#3667) Remove keyboard shortcuts from plugin registration * fix(Revit): DirectShape Instances to Speckle Conversion support (#3572) For POC purposes - implements a fix - needs investigation * Jrm/ci fix (#3670) * Ensure CI runs on net8 * remove net 7 * bump csharpier for net8 support * ensure net8 sdk is available on connector builds * relax rollforward rules instead * Fixed email invites (#3669) * removed chunking from model class. (#3668) Co-authored-by: Jedd Morgan <45512892+JR-Morgan@users.noreply.github.com> * CNX-619 Revit Analytical Panel (#3645) * File Added: ConvertStructuralMaterial Separated methods pertaining to StructuralMaterial outside of the ConvertAnalyticalStick.cs file. Didn't make sense that these functions were in the ConvertAnalyticalStick.cs when the ConvertAnalyticalSurface.cs referenced them * ScaleToSpeckle Material properties were sent as revit internal units. Inconsistent with the Revit model / project units. These can't be used for connection applications (e.g. receiving analytical elements in ETABS) * ETABS Receive Property2D ETABS currently only created properties for Element2Ds with a CSIProperty2D, but what about Property2D? These should also be received without us defaulting to the "Slab1" ETABS section. * ETABS Receive Wall Property Walls were previously assigned with slab sections which is incorrect. The WallPropertyToNative() was implemented (previously raised a ConversionNotSupportedException for some reason) * RVT 22 Scaling Updates Testing on Revit 2022 - ETABS connection * Default Fallback Assign at least something to Element2D * Fixed shared project case sensitivity * IDE0005 --------- Co-authored-by: Jedd Morgan <45512892+JR-Morgan@users.noreply.github.com> * Revert deploy step to use .NET 6 SDK for Manager Feed (#3671) * Fix ping in SDK and add user agent headers (#3672) * ping should ping a static asset and add user agent headers * fix: fmt * Removed frontend headers check for FE1 servers * Removed another test that relied on this pinging --------- Co-authored-by: Dimitrie Stefanescu <didimitrie@gmail.com> Co-authored-by: Jedd Morgan <45512892+JR-Morgan@users.noreply.github.com> * Remove Node Run events from GH nodes (#3674) Removed tracking for grasshopper node runs * Ping `/api/ping` with fallbacks to older style pings (#3676) * Multi-ping * tests * adjusted timeouts * Removed favourite stream count from DUI2 stream view (#3675) * Jrm/optimise query (#3677) * Optimised large queries * fix mistake * Jrm/optimise query (#3678) * Optimised large queries * fix mistake * fix another mistake * fix: Disappearing Grasshopper components after save (#3679) * fix: Dissapearing components after save SyncReceive would disappear upon opening a document (or while saving) due to exceptions being thrown in the Read/Write logic, which shouldn't ever throw. * fix: Write method for Kit name is unnecessary, dealt with in parent class * fix(gh): Use external getter for `Value` property (#3680) Do not assume internal storage `m_value` will exist in all GH_Goo's, some have varying implementation, but `Value` is usually consistent on all pre-rhino8 GH types * Branch get nullabilty * fixed test warnings * Fix perf tests --------- Co-authored-by: Alan Rynne <alan@speckle.systems> Co-authored-by: Jonathon Broughton <760691+jsdbroughton@users.noreply.github.com> Co-authored-by: Mucahit Bilal GOKER <51519350+bimgeek@users.noreply.github.com> Co-authored-by: Björn Steinhagen <steinhagen.bjoern@gmail.com> Co-authored-by: Adam Hathcock <adamhathcock@users.noreply.github.com> Co-authored-by: Dimitrie Stefanescu <didimitrie@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several queries were setting the
commitsLimitto be0thinking that that would lead to zero commits queried.However,
0is often interpreted by our server to mean "default" and thus leads to lots of commits being requested unessearily.@gjedlicska identified one of these queries to be significantly taxing on the server.
In this PR I have:
0limit:0limit will be used to set aincludeCommits@includetag to prevent querying for commits when the caller passes in a limit of0.10commits out of laziness, even if they did not need to use anycommitdata, or just needed the latest commit, I've updated these to fetch an appropriate number of commits.branch.commitsqueries were fetching thebranchNameproperty of the commit. This is slow for the server to have to do for many commits, and as such, client side, we are only requesting thebranch.name, and then post-request, setting this value on all of the requested commits.projects/models/versionsAPI