-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dui3-175 Direct Shape conversion to native #8
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now minor comments, will test in 2h
Converters/Revit/Speckle.Converters.RevitShared/Helpers/ParameterValueSetter.cs
Show resolved
Hide resolved
Converters/Revit/Speckle.Converters.RevitShared/Helpers/RevitCategories.cs
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #8 +/- ##
========================================
+ Coverage 0.00% 0.02% +0.02%
========================================
Files 161 167 +6
Lines 3146 3444 +298
Branches 340 423 +83
========================================
+ Hits 0 1 +1
- Misses 3144 3441 +297
Partials 2 2 ☔ View full report in Codecov by Sentry. |
Description & motivation
Changes:
Helpers
Converters
To-do before merge:
Screenshots:
Finished product, rhino meshes in Revit
Validation of changes:
Checklist:
References