Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dui3-175 Direct Shape conversion to native #8

Merged
merged 12 commits into from
Jul 11, 2024
Merged

Conversation

connorivy
Copy link
Contributor

Description & motivation

Changes:

Helpers

  • ParameterValueSetter
    • Existing utility so translate base object parameters into Revit object parameters without knowing exactly what parameters are being set
  • Revit Categories
    • Removed a bunch of code that wasn't being used and added methods to get the revitCategory from an object.
      • I think this is grasshopper specific

Converters

  • All added converters are exising 'ToNative' methods in the current converter that have been slightly modified to remove redundant try catchs and change code styles

To-do before merge:

Screenshots:

image
Finished product, rhino meshes in Revit

Validation of changes:

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

References

@connorivy connorivy marked this pull request as ready for review July 8, 2024 12:41
Copy link
Member

@oguzhankoral oguzhankoral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now minor comments, will test in 2h

Copy link

codecov bot commented Jul 10, 2024

Codecov Report

Attention: Patch coverage is 0.24938% with 400 lines in your changes missing coverage. Please review.

Project coverage is 0.02%. Comparing base (8e7cfd0) to head (913be84).

Files Patch % Lines
...red/ToHost/TopLevel/BrepToHostTopLevelConverter.cs 0.00% 111 Missing ⚠️
...erters.RevitShared/Helpers/ParameterValueSetter.cs 1.19% 83 Missing ⚠️
...red/ToHost/TopLevel/MeshToHostTopLevelConverter.cs 0.00% 69 Missing ⚠️
...s.RevitShared/ToHost/Raw/SurfaceConverterToHost.cs 0.00% 59 Missing ⚠️
...ost/TopLevel/DirectShapeTopLevelConverterToHost.cs 0.00% 42 Missing ⚠️
...Shared/ToHost/Raw/RenderMaterialToHostConverter.cs 0.00% 19 Missing ⚠️
....Converters.RevitShared/Helpers/RevitCategories.cs 0.00% 11 Missing ⚠️
...rters.RevitShared/Services/ScalingServiceToHost.cs 0.00% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             dev      #8      +/-   ##
========================================
+ Coverage   0.00%   0.02%   +0.02%     
========================================
  Files        161     167       +6     
  Lines       3146    3444     +298     
  Branches     340     423      +83     
========================================
+ Hits           0       1       +1     
- Misses      3144    3441     +297     
  Partials       2       2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@connorivy connorivy merged commit c164860 into dev Jul 11, 2024
6 checks passed
@connorivy connorivy deleted the DUI3-175-Direct-Shapes branch July 11, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants