Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump SDK and enforce msbuild warnings #379

Draft
wants to merge 4 commits into
base: dev
Choose a base branch
from
Draft

Conversation

JR-Morgan
Copy link
Member

@JR-Morgan JR-Morgan commented Nov 9, 2024

Changes:

  • Bump CI to use SDK to 8.0.4xx
  • Bump required SDK version to 8.0.4xx (not sure if we're happy to do this, will check with Alan first)
  • Enforced msbuild warnings as errors in CI

Warning Fixes:

  • Bumped Tekla nugets to 2022.1 (released 1 day after 2022.0, fixes a dependency graph conflict between their sdk nugets)
  • Fixed Tekla platform targeting MSIL despite having x64 dependencies
  • Weird IL repack warnings
  • ArcGIS targets file containing unreachable code

Copy link

codecov bot commented Nov 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 8.39%. Comparing base (34457ea) to head (b2dd869).

Additional details and impacted files
@@          Coverage Diff          @@
##             dev    #379   +/-   ##
=====================================
  Coverage   8.39%   8.39%           
=====================================
  Files        237     237           
  Lines       4691    4691           
  Branches     513     513           
=====================================
  Hits         394     394           
  Misses      4281    4281           
  Partials      16      16           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JR-Morgan JR-Morgan marked this pull request as ready for review November 11, 2024 11:27
@JR-Morgan JR-Morgan changed the title Bump SDK (experimental don't merge) Bump SDK and enforce msbuild warnings Nov 11, 2024
@JR-Morgan
Copy link
Member Author

Delay merge until end of week to avoid any friction with Specklecon

@JR-Morgan JR-Morgan marked this pull request as draft November 11, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants