Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Send2 again! #372

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from
Open

Use Send2 again! #372

wants to merge 6 commits into from

Conversation

adamhathcock
Copy link
Member

Needed if this works out: specklesystems/speckle-sharp-sdk#164

@adamhathcock adamhathcock marked this pull request as ready for review November 12, 2024 14:54
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 8.37%. Comparing base (76ea67a) to head (2342443).

Files with missing lines Patch % Lines
...e.Connectors.Common/Operations/RootObjectSender.cs 0.00% 10 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             dev    #372      +/-   ##
========================================
- Coverage   8.38%   8.37%   -0.01%     
========================================
  Files        237     237              
  Lines       4701    4704       +3     
  Branches     513     513              
========================================
  Hits         394     394              
- Misses      4291    4294       +3     
  Partials      16      16              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@oguzhankoral oguzhankoral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no objection on connectors side!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants