-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jedd/cnx 590 resolve raceconditions where event handlers use the browser #287
Draft
JR-Morgan
wants to merge
15
commits into
dev
Choose a base branch
from
jedd/cnx-590-resolve-raceconditions-where-event-handlers-use-the-browser
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Jedd/cnx 590 resolve raceconditions where event handlers use the browser #287
JR-Morgan
wants to merge
15
commits into
dev
from
jedd/cnx-590-resolve-raceconditions-where-event-handlers-use-the-browser
+360
−221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
JR-Morgan
commented
Sep 27, 2024
•
edited
Loading
edited
- Fix tests
- Test a little more in connectors
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #287 +/- ##
========================================
+ Coverage 8.33% 8.99% +0.65%
========================================
Files 243 243
Lines 4857 4893 +36
Branches 569 570 +1
========================================
+ Hits 405 440 +35
Misses 4435 4435
- Partials 17 18 +1 ☔ View full report in Codecov by Sentry. |
…nt-handlers-use-the-browser
…nt-handlers-use-the-browser
Adam has suggested that an Event Aggregator pattern may also be a potential solution here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.