Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jedd/cnx 590 resolve raceconditions where event handlers use the browser #287

Draft
wants to merge 15 commits into
base: dev
Choose a base branch
from

Conversation

JR-Morgan
Copy link
Member

@JR-Morgan JR-Morgan commented Sep 27, 2024

  • Fix tests
  • Test a little more in connectors

Copy link

codecov bot commented Oct 2, 2024

Codecov Report

Attention: Patch coverage is 59.70149% with 27 lines in your changes missing coverage. Please review.

Project coverage is 8.99%. Comparing base (0c5b5ed) to head (b7bfcdb).

Files with missing lines Patch % Lines
...UI3/Speckle.Connectors.DUI/Bridge/BrowserBridge.cs 0.00% 21 Missing ⚠️
...rs.DUI/Bindings/TopLevelExceptionHandlerBinding.cs 0.00% 4 Missing ⚠️
...I3/Speckle.Connectors.DUI/Bridge/SyncToUIThread.cs 0.00% 1 Missing ⚠️
....Connectors.DUI/Bridge/TopLevelExceptionHandler.cs 92.30% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             dev    #287      +/-   ##
========================================
+ Coverage   8.33%   8.99%   +0.65%     
========================================
  Files        243     243              
  Lines       4857    4893      +36     
  Branches     569     570       +1     
========================================
+ Hits         405     440      +35     
  Misses      4435    4435              
- Partials      17      18       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JR-Morgan JR-Morgan marked this pull request as ready for review October 2, 2024 10:41
@JR-Morgan
Copy link
Member Author

Adam has suggested that an Event Aggregator pattern may also be a potential solution here.
I think this could be cleaner, so I'll give it a POC.

@JR-Morgan JR-Morgan marked this pull request as draft October 14, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants