-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SDK is non static and logging/tracing controls are moved to the connectors #239
Merged
adamhathcock
merged 18 commits into
dev
from
adam/cxpla-51-make-sdk-setup-and-logging-use-a-container-for-logging
Sep 18, 2024
Merged
SDK is non static and logging/tracing controls are moved to the connectors #239
adamhathcock
merged 18 commits into
dev
from
adam/cxpla-51-make-sdk-setup-and-logging-use-a-container-for-logging
Sep 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-setup-and-logging-use-a-container-for-logging
…-setup-and-logging-use-a-container-for-logging
JR-Morgan
reviewed
Sep 18, 2024
AlanRynne
reviewed
Sep 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a bunch of comments
Connectors/Autocad/Speckle.Connectors.AutocadShared/Plugin/AutocadRibbon.cs
Show resolved
Hide resolved
Sdk/Speckle.Connectors.Logging/Internal/SpeckleLogLevelUtility.cs
Outdated
Show resolved
Hide resolved
…-setup-and-logging-use-a-container-for-logging
…a-container-for-logging
AlanRynne
approved these changes
Sep 18, 2024
…a-container-for-logging
adamhathcock
deleted the
adam/cxpla-51-make-sdk-setup-and-logging-use-a-container-for-logging
branch
September 18, 2024 14:13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs specklesystems/speckle-sharp-sdk#116 as a NuGet to fix up references and Solution
https://www.figma.com/board/h0HKFlItQRmI8WYQ5AGmbm/Connector-Dependencies?node-id=0-1&node-type=canvas&t=LRBQV8i4iEqGhBFM-0