Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK is non static and logging/tracing controls are moved to the connectors #239

Conversation

adamhathcock
Copy link
Member

@adamhathcock adamhathcock commented Sep 13, 2024

Copy link

linear bot commented Sep 13, 2024

@adamhathcock adamhathcock marked this pull request as ready for review September 17, 2024 15:07
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 133 lines in your changes missing coverage. Please review.

Project coverage is 7.38%. Comparing base (1dbb2b6) to head (e20403b).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...dk/Speckle.Connectors.Utils/AutofacRegistration.cs 0.00% 44 Missing ⚠️
Sdk/Speckle.Connectors.Utils/Connector.cs 0.00% 24 Missing ⚠️
...eckle.Connectors.Utils/ConnectorActivityFactory.cs 0.00% 19 Missing ⚠️
...le.Connectors.Utils/Operations/ReceiveOperation.cs 0.00% 14 Missing ⚠️
...le.Connectors.Utils/Operations/RootObjectSender.cs 0.00% 8 Missing ⚠️
...ckle.Connectors.Utils/Common/AssemblyExtensions.cs 0.00% 7 Missing ⚠️
...eckle.Connectors.Utils/Operations/SendOperation.cs 0.00% 7 Missing ⚠️
.../Speckle.Connectors.DUI/Bindings/AccountBinding.cs 0.00% 3 Missing ⚠️
...ckle.Connectors.Utils/Operations/AccountService.cs 0.00% 3 Missing ⚠️
Sdk/Speckle.Connectors.Utils/SpeckleLogProvider.cs 0.00% 3 Missing ⚠️
... and 1 more
Additional details and impacted files
@@           Coverage Diff            @@
##             dev    #239      +/-   ##
========================================
- Coverage   7.51%   7.38%   -0.14%     
========================================
  Files        241     243       +2     
  Lines       4683    4767      +84     
  Branches     548     564      +16     
========================================
  Hits         352     352              
- Misses      4316    4400      +84     
  Partials      15      15              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@AlanRynne AlanRynne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a bunch of comments

@adamhathcock adamhathcock enabled auto-merge (squash) September 18, 2024 12:04
@adamhathcock adamhathcock merged commit 4a2233e into dev Sep 18, 2024
5 checks passed
@adamhathcock adamhathcock deleted the adam/cxpla-51-make-sdk-setup-and-logging-use-a-container-for-logging branch September 18, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants