Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(autocad): Evaluate mid point with angle #238

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

oguzhankoral
Copy link
Member

I believe we were evaluating mid point with params, seems like it was a wrong approach. target.EvaluatePoint(midAngle) seems doing good so far.

BEFORE
chrome_AermPOeF9T

AFTER
chrome_Enom68gxRw

TRIED TO BREAK IT
image
chrome_a9erSYLBF8

Copy link

linear bot commented Sep 12, 2024

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 7.40%. Comparing base (3d64a3c) to head (55e8ad8).
Report is 2 commits behind head on dev.

Additional details and impacted files
@@          Coverage Diff          @@
##             dev    #238   +/-   ##
=====================================
  Coverage   7.40%   7.40%           
=====================================
  Files        242     242           
  Lines       4661    4661           
  Branches     548     548           
=====================================
  Hits         345     345           
  Misses      4301    4301           
  Partials      15      15           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@didimitrie didimitrie merged commit 359954c into dev Sep 13, 2024
5 checks passed
@didimitrie didimitrie deleted the oguzhan/cnx-436-autocad-wrong-arc-conversions-again branch September 13, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants