chore(fileimport service): Part 1 - port to typescript as-is #3962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
📸 Preview service has generated an image. |
|
📸 Preview service has generated an image. |
iainsproat
changed the title
iainsproat
commented
Feb 12, 2025
| @@ -58,7 +98,7 @@ module.exports = class ServerAPI { | |||
| delete insertionObject.__tree | |||
| delete insertionObject.__closure | |||
|
|
|||
| insertionObject.totalChildrenCount = object.__closures.length | |||
| insertionObject.totalChildrenCount = object.__closure?.length | |||
There was a problem hiding this comment.
Typescript caught a bug here 🐛
| @@ -224,9 +243,24 @@ async function doTask(mainDb, regionName, taskDb, task) { | |||
| throw new Error(`File type ${info.fileType} is not supported`) | |||
| } | |||
|
|
|||
| const output = JSON.parse(fs.readFileSync(TMP_RESULTS_PATH)) | |||
| const output: unknown = JSON.parse(fs.readFileSync(TMP_RESULTS_PATH, 'utf8')) | |||
There was a problem hiding this comment.
And another possible bug here caught by typescript 🐛
|
📸 Preview service has generated an image. |
|
📸 Preview service has generated an image. |
|
📸 Preview service has generated an image. |
|
📸 Preview service has generated an image. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation
Typescript port of some of the FileImport service. No other refactoring (apart from a directory nest).
Copy & paste of the preview service typescript boilerplate.
Changes:
/srcdirectory within file import packageTo-do before merge:
Screenshots:
Validation of changes:
Checklist:
References