Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(logging): knex should use pino logger and not compile sql on error in production #2743

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

iainsproat
Copy link
Contributor

  • knex should use pino logger as its internal logger
  • knex should not compile sql on error in production environments as this may leak sensitive values

Description & motivation

Changes:

To-do before merge:

Screenshots:

Validation of changes:

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

References

- knex should not compile sql on error in production environments
@iainsproat iainsproat marked this pull request as ready for review August 23, 2024 12:03
@iainsproat iainsproat changed the title fix(logging): knex should use pino logger fix(logging): knex should use pino logger and not compile sql on error in production Aug 23, 2024
@gjedlicska gjedlicska merged commit 143c830 into main Aug 23, 2024
22 of 24 checks passed
@gjedlicska gjedlicska deleted the iain/knex-logging-use-pino branch August 23, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants