Alessandro/web 1659 workspace limits #2733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alessandro/web-1659-workspace-limits
alemagio
commented
Aug 22, 2024
packages/server/modules/workspaces/tests/integration/workspaces.graph.spec.ts
Show resolved
Hide resolved
gjedlicska
requested changes
Aug 23, 2024
| } | ||
|
|
||
| type WorkspaceBilling { | ||
| version: WorkspaceBillingVersion |
There was a problem hiding this comment.
lets call this versionCount
| @@ -153,6 +153,21 @@ input PendingWorkspaceCollaboratorsFilter { | |||
| search: String | |||
| } | |||
|
|
|||
| type WorkspaceBillingVersion { | |||
There was a problem hiding this comment.
type WorkspaceVersionCount
| @@ -1 +1,2 @@ | |||
| export const WorkspaceInviteResourceType = 'workspace' | |||
| export const WORKSPACE_MAX_PROJECTS_VERSIONS = 500 | |||
There was a problem hiding this comment.
This could be moved to the gatekeeper module
| .where({ workspaceId }) | ||
| .count(StreamCommits.col.commitId) | ||
|
|
||
| return Number(res.count) |
There was a problem hiding this comment.
prob parseInt is more correct
| async ({ workspaceId }) => { | ||
| const [res] = await tables | ||
| .workspaces(db) | ||
| .join(Streams.name, Streams.col.workspaceId, Workspaces.col.id) |
There was a problem hiding this comment.
you can just query the Streams table
…alessandro/web-1659-workspace-limits
…alessandro/web-1659-workspace-limits
…alessandro/web-1659-workspace-limits
gjedlicska
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation
Changes:
To-do before merge:
Screenshots:
Validation of changes:
Checklist:
References