chore(server): remove sentry and only apply mixpanel middleware if enabled

[iainsproat]

Description & motivation

We are no longer using Sentry, we should purge it from our source code.

We should always respect the flag for enabling (or disabling) MixPanel.

Changes:

• MixPanel middleware is only enabled where Mixpanel is configured to be enabled
• All references to Sentry are removed.

To-do before merge:

Screenshots:

Validation of changes:

Checklist:

• My pull request follows the guidelines in the Contributing guide?
• My pull request does not duplicate any other open Pull Requests for the same update/change?
• My commits are related to the pull request and do not amend unrelated code or documentation.
• My code follows a similar style to existing code.
• I have added appropriate tests.
• I have updated or added relevant documentation.

References

[iainsproat]

These are not being used at the moment, but can be reinstated if we ever add tracing.

[cdriesler]

TIL, I've been meaning to ask

[cdriesler]

I believe the calls to mixpanel() are already protected by the if (client) block within it - as in the client won't exist if mixpanel is not enabled, and so these calls (should) no-op in that case.

It looks like you may have made this (more) correct with the changes in app.ts, though. Maybe worth at least including this behavior in the comment on mixpanel()?

[iainsproat]

I believe the calls to mixpanel() are already protected by the if (client) block within it - as in the client won't exist if mixpanel is not enabled, and so these calls (should) no-op in that case.

It looks like you may have made this (more) correct with the changes in app.ts, though. Maybe worth at least including this behavior in the comment on mixpanel()?

Thanks @cdriesler - I've reverted the change to the calls to mixpanel in automate. I see that it returns if the client doesn't exist:

speckle-server/packages/server/modules/shared/utils/mixpanel.ts

Line 69 in ff9a9e1

if (client) {

And the client only exists if MixPanel is enabled:

speckle-server/packages/server/modules/shared/utils/mixpanel.ts

Line 27 in ff9a9e1

if (client || !enableMixpanel()) return