Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(/api/diff): fix debug log pollution #2704

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Conversation

iainsproat
Copy link
Contributor

Description & motivation

When run in debug log level, /api/diff caused the list of objects to include log properties. Removes the offending log line.

Changes:

To-do before merge:

Screenshots:

Validation of changes:

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

References

@iainsproat iainsproat marked this pull request as ready for review August 20, 2024 11:44
@iainsproat iainsproat merged commit 4d82e1f into main Aug 20, 2024
22 of 24 checks passed
@iainsproat iainsproat deleted the iain/fix-debug-log branch August 20, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant