Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix(server): revert 55cad9662a0f5b85916759d7bd57ffd3f117e7fd (#2633)" #2650

Merged

Conversation

iainsproat
Copy link
Contributor

This reverts commit f2c5677.

Description & motivation

This was originally reverted out of an abundance of caution due to an incident affecting the Objects API. The incident symptoms re-occurred despite this reversion, so the code is deemed unrelated to the incident.

This code adds diagnostics which may actually help with debugging the incident.

Changes:

To-do before merge:

Screenshots:

Validation of changes:

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

References

@iainsproat iainsproat marked this pull request as ready for review August 13, 2024 09:52
@iainsproat iainsproat merged commit 60251e4 into main Aug 13, 2024
22 of 24 checks passed
@iainsproat iainsproat deleted the iain/revert-f2c5677b4abab69f487d9f0bda5dee3b107c069e branch August 13, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants