Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(liveness): fail liveness if db conns saturated for 10min #2648

Merged
merged 2 commits into from
Aug 13, 2024

Conversation

iainsproat
Copy link
Contributor

@iainsproat iainsproat commented Aug 13, 2024

Description & motivation

Pods are placed in an unready state if the database connections are saturated for >20 seconds.

We currently have a situation where there are some long-running database queries. These cause the database connections available to a pod to be saturated for extended periods of time. This in turn causes the pod to be in an unready state. Over time, as the long-running queries accumulate, the number of pods which are unready increases. This eventually causes the entire cluster to be unavailable.

Currently the only way to recover is to restart the pod.

Including a check of saturated database connections in the liveness probe is a short-term hack to ensure affected pods are restarted whenever the encounter this issue.

Changes:

To-do before merge:

Screenshots:

Validation of changes:

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

References

@iainsproat iainsproat changed the title chore(liveness): fail liveness if db conns saturated for 2min chore(liveness): fail liveness if db conns saturated for 10min Aug 13, 2024
@iainsproat iainsproat marked this pull request as ready for review August 13, 2024 09:46
Copy link
Contributor

@fabis94 fabis94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷

@gjedlicska gjedlicska merged commit a262d7d into main Aug 13, 2024
22 of 24 checks passed
@gjedlicska gjedlicska deleted the iain/livenessprobe-fail-if-saturated-db-conns branch August 13, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants