feat(fe2): invite + list workspace invites #2629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabis94
commented
Aug 9, 2024
| show-clear | ||
| :placeholder="searchPlaceholder" | ||
| class="rounded-md border border-outline-3" | ||
| v-bind="bind" |
There was a problem hiding this comment.
Improved useDebouncedTextInput return to allow for way simpler/easier configuration of the FormTextInput component
fabis94
commented
Aug 9, 2024
| @@ -92,7 +92,7 @@ | |||
| </div> | |||
| <div | |||
| v-if="hasButtons" | |||
| class="relative z-50 flex px-6 py-3 space-x-3 shrink-0 bg-foundation-page border-t border-outline-2" | |||
| class="relative z-50 flex px-6 py-3 space-x-3 shrink-0 bg-foundation-page" | |||
There was a problem hiding this comment.
None of Michal's new dialogs have a border above the button footer
fabis94
commented
Aug 9, 2024
| @@ -21,7 +20,17 @@ | |||
| class="divide-y divide-outline-3 h-full overflow-visible" | |||
| :class="{ 'pb-32': overflowCells }" | |||
| > | |||
| <template v-if="items.length"> | |||
| <div | |||
| v-if="loading || !items" | |||
There was a problem hiding this comment.
Undefined items now means - show loading bar (for easy feeding in of API data). Additionally you can manually enable the loading bar through loading
fabis94
commented
Aug 9, 2024
| @@ -0,0 +1,157 @@ | |||
| <template> | |||
There was a problem hiding this comment.
Moved+Updated Mike's table
fabis94
commented
Aug 9, 2024
cdriesler
previously approved these changes
Aug 11, 2024
| @@ -313,23 +313,23 @@ const revolveFieldNameAndVariables = < | |||
| * full objects. Read more: https://www.apollographql.com/docs/react/caching/cache-interaction/#values-vs-references | |||
| */ | |||
| export function modifyObjectFields< | |||
| V extends Optional<Record<string, unknown>> = undefined, | |||
| D = unknown | |||
| Variables extends Optional<Record<string, unknown>> = undefined, | |||
Mikehrn
requested changes
Aug 12, 2024
Mikehrn
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.