refactor(server/upload): convert js to ts #2618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gjedlicska
approved these changes
Aug 9, 2024
fabis94
approved these changes
Aug 9, 2024
| const { ObjectHandlingError } = require('@/modules/core/errors/object') | ||
| const { estimateStringMegabyteSize } = require('@/modules/core/utils/chunking') | ||
| const { toMegabytesWith1DecimalPlace } = require('@/modules/core/utils/formatting') | ||
| } from '@/modules/core/services/objects' |
There was a problem hiding this comment.
Do make sure to test this, sometimes imports don't act as expected when converting from require() to import(), e.g. const XXX = require('asd') is not necessarily always translated to a default import.
| @@ -69,7 +78,7 @@ module.exports = (app) => { | |||
| } | |||
| let totalObjectsProcessed = 0 | |||
|
|
|||
| const promises = [] | |||
| const promises: Promise<boolean | void | string[]>[] = [] | |||
There was a problem hiding this comment.
if the promise result is irrelevant you can just do Promise<unknown>
iainsproat
added a commit
that referenced
this pull request
Aug 12, 2024
This reverts commit e9f7286.
iainsproat
added a commit
that referenced
this pull request
Aug 12, 2024
This reverts commit e9f7286.
iainsproat
added a commit
that referenced
this pull request
Aug 12, 2024
* Revert "refactor(server/upload): convert js to ts (#2618)" This reverts commit e9f7286. * Revert "feat(logging): pass request logger to core/services/objects (#2599)" This reverts commit ee3e9af. * Revert "feat(server): configurable maximum objects POST size and improved logging (#2594)" This reverts commit 55cad96.
iainsproat
added a commit
that referenced
this pull request
Aug 12, 2024
* Revert "refactor(server/upload): convert js to ts (#2618)" This reverts commit e9f7286. * Revert "feat(logging): pass request logger to core/services/objects (#2599)" This reverts commit ee3e9af. * Revert "feat(server): configurable maximum objects POST size and improved logging (#2594)" This reverts commit 55cad96.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation
Typescript all the things 🧹 , well
packages/server/modules/core/rest/upload.jsat leastChanges:
To-do before merge:
Screenshots:
Validation of changes:
Checklist:
References