Feat: Allow users to manage emails #2613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewwallacespeckle
previously approved these changes
Aug 8, 2024
fabis94
previously approved these changes
Aug 9, 2024
|
|
||
| export const settingsUserEmailsQuery = graphql(` | ||
| query SettingsUserEmailsQuery { | ||
| activeUser { |
There was a problem hiding this comment.
All of the ActiveUser fields should be its own SettingsUserEmail_User fragment that you can then reference in all of the mutations, instead of duplicating id and emails every time
There was a problem hiding this comment.
Makes sense, I've updated it :) Everything works with the cache, didn't run into any issues when testing
Mikehrn
dismissed stale reviews from fabis94 and andrewwallacespeckle
via
445b4ed
fabis94
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds "Email addresses" page to the user settings