WEB-1261 #2478
Merged
WEB-1261 #2478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f a TAS batch object and we can no longer get a min dist from that batch object, we just use the fallback emipiric value. Also added an option to display TAS BVH for debuging purposes
didimitrie
previously approved these changes
Jul 9, 2024
didimitrie
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation
Fixes https://linear.app/speckle/issue/WEB-1261/nearplanecalculationaccurate-fails-for-meshes-that-have-disjointed
For meshes made out of disjoint sets, just querying the TAS when computing the camera near plane did not yield correct values, issue seen in the video below
bandicam.2024-07-08.13-47-25-740.mp4
The objects in the video, are actually a single mesh made out of disjoint pieces. It's this case in particular that we need to fix near plane computation for.
So we did, by using the fallback empiric near plane value when the camera gets inside the bounds of a batch object when traversing the TAS. Video below shows the same stream with the fix
bandicam.2024-07-08.13-48-15-050.mp4
Changes:
To-do before merge:
Screenshots:
Validation of changes:
Checklist:
References