Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: change ServerManagementTable to LayoutTable #2447

Merged
merged 2 commits into from
Jun 28, 2024

Conversation

Mikehrn
Copy link
Contributor

@Mikehrn Mikehrn commented Jun 27, 2024

In the new settings modal we will change the styling of the tables, in order to do this this PR changes the tables that will be included in the settings modal from the ServerManagementTable to the LayoutTable, so we can apply the new styling consistently.

I tested the loading/search logic and styling across pages, and all seems to be working as expected using the LayoutTable

Screenshot 2024-06-27 at 15 41 53 Screenshot 2024-06-27 at 15 41 45 Screenshot 2024-06-27 at 15 41 39

@Mikehrn Mikehrn self-assigned this Jun 27, 2024
@Mikehrn Mikehrn changed the title Mike/move server management table to layout table Change ServerManagementTable to LayoutTable Jun 27, 2024
Copy link
Contributor

@benjaminvo benjaminvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! I also tested it ✅

Copy link
Contributor

@fabis94 fabis94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mikehrn Mikehrn changed the title Change ServerManagementTable to LayoutTable Fix: change ServerManagementTable to LayoutTable Jun 28, 2024
@Mikehrn Mikehrn merged commit 7f8946b into main Jun 28, 2024
21 of 23 checks passed
@Mikehrn Mikehrn deleted the mike/move-server-management-table-to-layout-table branch June 28, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants