feat(fe2): Improve property name display and search functionality in filtering #2396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabis94
requested changes
Jun 19, 2024
fabis94
requested changes
Jun 20, 2024
| return revitPropertyRegex.test(key) | ||
| } | ||
|
|
||
| const getPropertyName = (key: string): string => { |
There was a problem hiding this comment.
Seems like everywhere where we use this fn we have access to the entire filter object. If we pass that in, instead of just the key, we don't have to do the props.filters.find() bit
There was a problem hiding this comment.
Passing the entire filter object introduced complexity with a fallback mechanism and error handling in title. Let me know if this is enough to stop us merging and I can take another look on Monday but I'm running out of time today
…-of-searchable-properties
…-of-searchable-properties
…-of-searchable-properties
This reverts commit 21aaabd.
fabis94
previously approved these changes
Jun 21, 2024
fabis94
approved these changes
Jun 21, 2024
andrewwallacespeckle
deleted the
andrew/web-462-output-property-names-in-list-of-searchable-properties
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation
This PR addresses user feedback from the forums regarding the display of property names and the search functionality in our UI for Revit files. Users requested more user-friendly property names instead of raw database keys and improved search capabilities.
Changes: