feat: sourcemaps + testing #2366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iainsproat
reviewed
Jun 13, 2024
| @@ -22,6 +22,8 @@ const isLogPretty = ['1', 'true', true, 1].includes(NUXT_PUBLIC_LOG_PRETTY) | |||
|
|
|||
| // https://v3.nuxtjs.org/api/configuration/nuxt.config | |||
| export default defineNuxtConfig({ | |||
| // sourcemaps in prod only needed for datadog and should be deleted after (or at least made inaccessible?) | |||
There was a problem hiding this comment.
It's open source, so I don't see any need to delete them (provided they don't make the image too heavy)
|
Example sourcemap upload command: |
Where is the domain provided @fabis94 ? Is this the service? |
|
@iainsproat --minified-path-prefix is the bit that includes the domain of the app |
|
Apparently we may be able to avoid having to specify the app domain, and we can just specify the path prefix that leads to the minified assets (/_nuxt) |
iainsproat
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
generate source maps in prod build + allow devs to trigger errors (for now) through secret query param