Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix(fe2): Coloring function disappears if parameter title is too long #2255

Merged
merged 5 commits into from
May 16, 2024
Merged

bugfix(fe2): Coloring function disappears if parameter title is too long #2255

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bb63350
Add truncation to filter name
andrewwallacespeckle May 14, 2024
b86e1d8
Use shortened model name in scene explorer
andrewwallacespeckle May 14, 2024
40d3b6e
Revert "Use shortened model name in scene explorer"
andrewwallacespeckle May 14, 2024
a11124b
Remove gap
andrewwallacespeckle May 16, 2024
8e6cfb6
Merge branch 'main' into andrew/web-862-coloring-function-disappears-…
andrewwallacespeckle May 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions packages/frontend-2/components/viewer/explorer/Filters.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,19 +2,19 @@
<ViewerLayoutPanel class="mt-2" hide-close>
<template #title>Filtering</template>
<template #actions>
<div class="flex justify-between items-center w-full">
<div class="-mt-1">
<FormButton
v-tippy="'Change Filter'"
text
size="xs"
:icon-right="showAllFilters ? ChevronUpIcon : ChevronDownIcon"
class="capitalize"
@click="showAllFilters = !showAllFilters"
>
<div class="flex justify-between items-center w-full gap-2">
<FormButton
v-tippy="'Change Filter'"
text
size="xs"
:icon-right="showAllFilters ? ChevronUpIcon : ChevronDownIcon"
class="capitalize"
benjaminvo marked this conversation as resolved.
Show resolved Hide resolved
@click="showAllFilters = !showAllFilters"
>
<span class="max-w-20 md:max-w-36 truncate">
{{ title.split('.').reverse()[0] || title || 'No Title' }}
</FormButton>
</div>
</span>
</FormButton>
<div class="flex gap-1 divide-x divide-outline-3">
<FormButton
v-if="title !== 'Object Type'"
Expand Down