Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2182 Undead patch-1 #2188

Merged
merged 1 commit into from
Apr 3, 2024
Merged

#2182 Undead patch-1 #2188

merged 1 commit into from
Apr 3, 2024

Conversation

AlexandruPopovici
Copy link
Contributor

@AlexandruPopovici AlexandruPopovici commented Apr 2, 2024 •
edited
Loading

Description & motivation

Undead patch No.1 for #2182

Changes:

  • Material index edges now read from forward or backward edges depending on the edge's starting node value

To-do before merge:

Screenshots:

Validation of changes:

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

References

@linear Linear
Copy link

linear bot commented Apr 2, 2024

WEB-695 Batching Attention

@AlexandruPopovici AlexandruPopovici changed the title Fixed an issue with material indices edges #2182 Undead patch-1 Apr 2, 2024
@fabis94
Copy link
Contributor

fabis94 commented Apr 3, 2024

thrgiphy

@AlexandruPopovici AlexandruPopovici merged commit 4ee8a3f into main Apr 3, 2024
20 of 23 checks passed
@AlexandruPopovici AlexandruPopovici deleted the alex/WEB-695-undead-patch-1 branch April 3, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabis94 fabis94 fabis94 approved these changes

@benjaminvo benjaminvo Awaiting requested review from benjaminvo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexandruPopovici @fabis94