Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ingress): simplify ingress and avoid regex warning #2187

Merged
merged 2 commits into from
Jun 21, 2024

Conversation

iainsproat
Copy link
Contributor

@iainsproat iainsproat commented Apr 2, 2024

Description & motivation

Changes:

To-do before merge:

  • deploy to a testing environment and validate all affected routes are handled correctly

Screenshots:

Validation of changes:

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

References

- removes regex from ingress to avoid confusion over warning: kubernetes/ingress-nginx#10200
- improves readability at expense of conciseness
@iainsproat iainsproat marked this pull request as ready for review June 18, 2024 11:03
@iainsproat
Copy link
Contributor Author

Tested in testing2 environment

@iainsproat iainsproat merged commit b5452de into main Jun 21, 2024
24 of 25 checks passed
@iainsproat iainsproat deleted the iain/fix-nginx-ingress-regex-warning branch June 21, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant