fix(server): startup crash if automate not enable due to missing scop…

…e for app (#2415)
specklesystems · Jun 20, 2024 · 423e02b · 423e02b
1 parent 69757fb
commit 423e02b
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 3 deletions.
diff --git a/packages/server/modules/auth/defaultApps.ts b/packages/server/modules/auth/defaultApps.ts
@@ -1,5 +1,9 @@
 import { Scopes } from '@/modules/core/helpers/mainConstants'
-import { speckleAutomateUrl, getServerOrigin } from '@/modules/shared/helpers/envHelper'
+import {
+  speckleAutomateUrl,
+  getServerOrigin,
+  getFeatureFlags
+} from '@/modules/shared/helpers/envHelper'
 
 export enum DefaultAppIds {
   Web = 'spklwebapp',
@@ -123,7 +127,9 @@ const SpeckleAutomate = {
     Scopes.Tokens.Write,
     Scopes.Streams.Read,
     Scopes.Streams.Write,
-    Scopes.Automate.ReportResults
+    ...(getFeatureFlags().FF_AUTOMATE_MODULE_ENABLED
+      ? [Scopes.Automate.ReportResults]
+      : [])
   ]
 }
 

diff --git a/packages/server/modules/index.js b/packages/server/modules/index.js
@@ -62,7 +62,16 @@ const getEnabledModuleNames = () => {
     'webhooks'
   ]
 
-  if (FF_AUTOMATE_MODULE_ENABLED) moduleNames.push('automate')
+  if (FF_AUTOMATE_MODULE_ENABLED) {
+    // Push in after 'auth', important for scope order?
+    const authIdx = moduleNames.indexOf('auth')
+    if (authIdx !== -1) {
+      moduleNames.splice(authIdx + 1, 0, 'automate')
+    } else {
+      moduleNames.push('automate')
+    }
+  }
+
   if (FF_GENDOAI_MODULE_ENABLED) moduleNames.push('gendo')
   return moduleNames
 }