-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recover branch selection #196
Recover branch selection #196
Conversation
7b3c161
to
5e01d5a
Compare
I haven't had a deep look at your PR just yet @overengineer Not sure if it relates to this PR. But I just thought I'd share my thoughts regardless. In other connectors, we have tried to use the account id / stream id / branch id / commit id as the key for the selection instead of a sequential index. I haven't investigated how possible this is, but we do look to be setting a Key here with This concept could also fix #98 |
Hi @JR-Morgan I used hooks to listen user actions. because I could not find a way to access selection states. I would prefer putting the code for selection states to a seperate file. But I hesitated because I do not know your folder structure conventions. If you have a suggestion, I can refactor. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, just a few comments
@JR-Morgan Also I converted class members to object members and instantiated the class. This way is less ugly I think. |
Thanks @overengineer for your patience, Thanks for you contribution! |
Change is now in 2.20.0-wip |
When user refreshes the stream, branch selection resets. As a workaround, I stored selected branch in a class member. Then used that value to get active branch. Better solutions are possible of course.