-
Notifications
You must be signed in to change notification settings - Fork 38
Update start and end period in GeologicTimePeriod when reversed #6434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Verify the start period is now greater than the end. start 200 - end 100
Looks good! Start periods are greater than the end period.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To clarify, this does not follow this request in the original issue:
if the user has not modified the defaults in any way.
That means all chronostratigraphic records will now switch the values, so the startPeriod
value should be larger than the endPeriod
value. This does not consider if the defaults have or have not been modified.
Do we understand why the chronostrat tree was initially set up as it was? Are we comfortable updating user-created data without notifying anyone?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: Add to release notes 👍
Fixes #5412
Warning
This PR affects database migrations. See migration testing instructions.
Checklist
self-explanatory (or properly documented)
Testing instructions