Skip to content

Update start and end period in GeologicTimePeriod when reversed #6434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 18, 2025

Conversation

CarolineDenis
Copy link
Contributor

Fixes #5412

Warning

This PR affects database migrations. See migration testing instructions.

Checklist

  • Self-review the PR after opening it to make sure the changes look good and
    self-explanatory (or properly documented)
  • Add relevant issue to release milestone

Testing instructions

  • Open a db with production that has geologic time period tree
  • Open a node
  • Find a node that has a start period greater than the start or create one or update one => start 100 - end 200
  • Save
  • Change the branch to use this pr and not prod
  • Open the node from the previous step
  • Verify the start period is now greater than the end. start 200 - end 100

@CarolineDenis CarolineDenis added this to the 7.11.0 milestone Apr 22, 2025
@github-project-automation github-project-automation bot moved this to 📋Back Log in General Tester Board Apr 22, 2025
@CarolineDenis CarolineDenis requested review from a team and acwhite211 May 30, 2025 16:07
Copy link
Contributor

@pashiav pashiav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Verify the start period is now greater than the end. start 200 - end 100

Looks good! Start periods are greater than the end period.

@pashiav pashiav requested a review from a team June 4, 2025 14:54
Copy link
Member

@grantfitzsimmons grantfitzsimmons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To clarify, this does not follow this request in the original issue:

if the user has not modified the defaults in any way.

That means all chronostratigraphic records will now switch the values, so the startPeriod value should be larger than the endPeriod value. This does not consider if the defaults have or have not been modified.

Do we understand why the chronostrat tree was initially set up as it was? Are we comfortable updating user-created data without notifying anyone?

@CarolineDenis CarolineDenis requested a review from a team June 5, 2025 15:16
Copy link
Contributor

@alesan99 alesan99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Verify the start period is now greater than the end. start 200 - end 100

I agree with Grant since it did change some of the chronostrat records I added myself, but functionality wise it worked without issue.

Left: New
Right: Old

chrome_B943qmM3I3

Values have been updated correctly 👍

@CarolineDenis CarolineDenis modified the milestones: 7.12.0, 7.11.1 Jun 12, 2025
Copy link
Member

@grantfitzsimmons grantfitzsimmons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: Add to release notes 👍

@CarolineDenis CarolineDenis merged commit 70e187d into main Jun 18, 2025
12 checks passed
@CarolineDenis CarolineDenis deleted the issue-5412 branch June 18, 2025 18:26
@github-project-automation github-project-automation bot moved this from 📋Back Log to ✅Done in General Tester Board Jun 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Default GeologicTimePeriod records are not linear between startPeriod and endPeriod
5 participants