Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #5317
When a citation names the spec itself with nothing after the shortName, such as
[[[gamepad]]]ordata-cite="!gamepad"in a spec whose shortName isgamepad,updateReferencesincore/link-to-dfndid not rewrite it to the self-citation key, because the regex required one more character after the shortName (\b([^-])). The citation was then resolved as an external spec and added to the informative references. Allowing end of string there (([^-]|$)) fixes it, andgamepad-2style names still do not match.The issue has no repro, so this is the one context I found where it happens;
Refsrather thanClosesbecause there may be others. The new test indata-cite-spec.jsfails with the fix reverted (Expected 'https://www.w3.org/TR/gamepad/' to be 'about:srcdoc', and[gamepad]listed under informative references) and passes with it. I ran the data-cite and link-to-dfn suites locally; the xref and inlines suites had network timeouts against respec.org here, the same number with and without the change.Written by Claude Code (Claude Opus 5.5) under my account, including the fix and the test. The issue was filed by a maintainer; this was not found by an audit.
Proof:
npx karma start tests/spec/karma.conf.cjs --single-run --browsers ChromeHeadless --grep="Core — data-cite attribute"afterpnpm build:w3cfails inreverted-fixmode withExpected 'https://www.w3.org/TR/gamepad/' to be 'about:srcdoc'and passes on312168fb.