Skip to content

Conversation

@mcbiscuit5173
Copy link

Add rounded-full to the primary button variant to ensure fully rounded corners.


Open in Cursor Open in Web

@cursor
Copy link

cursor bot commented Oct 23, 2025

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

@mcbiscuit5173 mcbiscuit5173 marked this pull request as ready for review October 23, 2025 15:41
@cursor
Copy link

cursor bot commented Oct 23, 2025

This PR is being reviewed by Cursor Bugbot

Details

Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

@cursor
Copy link

cursor bot commented Oct 23, 2025

Bug: Button Styling Conflict in Product Context

Adding rounded-full to the primary button variant conflicts with the component's context-based border radius system. This causes primary buttons in product context to incorrectly display rounded-full corners instead of rounded-sm, breaking the design system's intended styling.

Fix in Cursor Fix in Web

@cursor cursor bot force-pushed the cursor/round-primary-button-corners-7e93 branch from 5c7981d to 88c801d Compare October 23, 2025 15:50
@mcbiscuit5173
Copy link
Author

@cursoragent can you please amend the commit to use a conventional syntax like "feat:"

@cursor
Copy link

cursor bot commented Oct 23, 2025

Bug: Contextual Styling Overridden by Global Class

Adding rounded-full to the primary variant overrides the context-based border radius system. This causes primary buttons with context="product" to incorrectly display fully rounded corners instead of the intended rounded-sm.

Fix in Cursor Fix in Web

@cursor
Copy link

cursor bot commented Oct 23, 2025

I don't have permission to update the PR title directly, but I've already successfully updated the commit message to use conventional commit format:

Commit message: feat: add rounded-full border radius to primary button

The CI is failing because the PR title also needs the conventional commit prefix. You'll need to manually update the PR title from:

  • "Round primary button corners"

To:

  • "feat: round primary button corners"

This will resolve the CI check failure.


Open in Cursor Open in Web

Learn more about Cursor Agents

@mcbiscuit5173 mcbiscuit5173 changed the title Round primary button corners feat: add rounded-full border radius to primary button Oct 23, 2025
@mcbiscuit5173
Copy link
Author

@cursoragent I've updated the title please force push to force a rebuild

@cursor
Copy link

cursor bot commented Oct 23, 2025

Done! I've created an empty commit and pushed it to trigger the CI rebuild. The checks should now re-run with the updated PR title "feat: add rounded-full border radius to primary button" and the conventional commits check should pass. ✅


Open in Cursor Open in Web

Learn more about Cursor Agents

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants