chore: inline utility variants #306
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farazcsk
force-pushed
the
faraz/clean-up-tokens
branch
from
9c01221 to
4d3e12c
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Nope! Not unless the css variables were being used directly (which they shouldn't) |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Will need to check this as there might be some css modules but go ahead and we'll deal with it |
farazcsk
force-pushed
the
faraz/clean-up-tokens
branch
3 times, most recently
from
88019af to
8345e2b
Compare
Removes the need to create a new variable for each util.
farazcsk
force-pushed
the
faraz/clean-up-tokens
branch
from
8345e2b to
69d235d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the need to create a new variable for each util.
https://github.com/speakeasy-api/moonshine/compare/faraz/clean-up-tokens?expand=1#diff-e42e2039c8a4560f570e42afe10720975cfc608f80554433ca9799b87273a4e6
is the main file to review