Skip to content

Conversation

@ryan-timothy-albert
Copy link
Contributor

@ryan-timothy-albert ryan-timothy-albert commented Nov 6, 2025

  • fully connects server url tracking feature in opt in tool call logs

  • also cleans a few dead code paths from a previous PR

@ryan-timothy-albert ryan-timothy-albert requested a review from a team as a code owner November 6, 2025 22:03
@changeset-bot
Copy link

changeset-bot bot commented Nov 6, 2025

🦋 Changeset detected

Latest commit: abd6356

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
dashboard Patch
@gram/client Patch
server Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Nov 6, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
gram Ready Ready Preview Comment Nov 6, 2025 10:27pm
gram-docs-redirect Ready Ready Preview Comment Nov 6, 2025 10:27pm
gram-landing-redirect Ready Ready Preview Comment Nov 6, 2025 10:27pm

@@ -275,9 +275,6 @@ func (tp *ToolProxy) doFunction(
span.SetAttributes(attr.HTTPResponseStatusCode(responseStatusCode))
}()

toolCallLogger.RecordHTTPMethod(req.Method)
toolCallLogger.RecordHTTPRoute(req.URL.Path)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not entirely following why we're removing these

Copy link
Contributor Author

@ryan-timothy-albert ryan-timothy-albert Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They were mistakes I had left around from my previous PR. Redundant

@ryan-timothy-albert ryan-timothy-albert merged commit 77446ee into main Nov 6, 2025
21 checks passed
@ryan-timothy-albert ryan-timothy-albert deleted the connect_server_urls_to_tool_metrics branch November 6, 2025 23:02
@github-actions github-actions bot locked and limited conversation to collaborators Nov 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants