-
Notifications
You must be signed in to change notification settings - Fork 13
feat: fully connect server url in tool call logs #787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: abd6356 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
| @@ -275,9 +275,6 @@ func (tp *ToolProxy) doFunction( | |||
| span.SetAttributes(attr.HTTPResponseStatusCode(responseStatusCode)) | |||
| }() | |||
|
|
|||
| toolCallLogger.RecordHTTPMethod(req.Method) | |||
| toolCallLogger.RecordHTTPRoute(req.URL.Path) | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not entirely following why we're removing these
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They were mistakes I had left around from my previous PR. Redundant
fully connects server url tracking feature in opt in tool call logs
also cleans a few dead code paths from a previous PR