Fix #97 Duplicate extracted licenses when parsing from RDF #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pombredanne I've noticed that there aren't any RDF parsers tests where to add one for this issue. I could eventually write them, but is it OK to meanwhile write only the needed one(s) to test this? |
krysnuvadga
reviewed
Apr 14, 2019
|
@pombredanne @krysnuvadga I've written some unit tests for the fields that may have been affected by the change. |
xavierfigueroav
force-pushed
the
rdfparser-duplicate-ext-lic
branch
2 times, most recently
from
f1348e6 to
9ad3993
Compare
|
@xavierfigueroav This needs some rebasing |
xavierfigueroav
force-pushed
the
rdfparser-duplicate-ext-lic
branch
from
9ad3993 to
693f801
Compare
|
@pombredanne Rebased! |
Signed-off-by: Xavier Figueroa <xavierfigueroav@gmail.com>
Signed-off-by: Xavier Figueroa <xavierfigueroav@gmail.com>
xavierfigueroav
force-pushed
the
rdfparser-duplicate-ext-lic
branch
from
693f801 to
f0af856
Compare
|
All merged. Thank you again :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #97
The field Document.extracted_licenses contained duplicate ExtractedLicense objects when they are parsed from RDF files. Both extracted licenses in
<licenseConcluded>and<licenseDeclared>were being added twice.This PR makes extracted licenses are parsed only once, when
<SpdxDocument>is being parsed.Signed-off-by: Xavier Figueroa xavierfigueroav@gmail.com