Allow URLs with capital letters #833
Conversation
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
|
The Java validator allows URLs with capitals. |
|
Thanks for catching and fixing this! Would you mind adding appropriate test cases to the |
|
Humm, I would need some help with the testing @armintaenzertng . It looks like if I run pytest in my dev branch it is not running my modified code. I did pip3 install the local folder before, but still it seems that my changes are not running. Can you help me to figure this out? |
|
@meretp can you help me with this testing issue? |
|
@CsatariGergely sure, what exactly did you try? I don't see a test on this branch so I can't really reproduce your issue right now, did you follow the instructions from the Contributing.md file? |
|
also, it would be good if you could rebase your changes on main and not merge the changes from main into this branch to keep the history clean |
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
|
@meretp Thanks I think I've figured out the tests. I just did not know where to add an URI with capitals to test. |
|
@meretp , @armintaenzertng what else is missing to get this merged? |
Fixes: #832