Skip to content

Allow URLs with capital letters #833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

CsatariGergely
Copy link

Fixes: #832

Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
@CsatariGergely
Copy link
Author

The Java validator allows URLs with capitals.

@armintaenzertng
Copy link
Collaborator

Thanks for catching and fixing this!

Would you mind adding appropriate test cases to the test_valid_url test to document this behavior?

@CsatariGergely
Copy link
Author

Humm, I would need some help with the testing @armintaenzertng . It looks like if I run pytest in my dev branch it is not running my modified code. I did pip3 install the local folder before, but still it seems that my changes are not running. Can you help me to figure this out?

@CsatariGergely
Copy link
Author

@meretp can you help me with this testing issue?

@meretp
Copy link
Collaborator

meretp commented May 26, 2025

@CsatariGergely sure, what exactly did you try? I don't see a test on this branch so I can't really reproduce your issue right now, did you follow the instructions from the Contributing.md file?

@meretp
Copy link
Collaborator

meretp commented May 26, 2025

also, it would be good if you could rebase your changes on main and not merge the changes from main into this branch to keep the history clean

Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
@CsatariGergely
Copy link
Author

@meretp Thanks I think I've figured out the tests. I just did not know where to add an URI with capitals to test.
I've rebased to current main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

URLs with capital letters fail on the URL check
3 participants