Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 611 fix xml parser #612

Merged
merged 3 commits into from
Apr 24, 2023
Merged

Issue 611 fix xml parser #612

merged 3 commits into from
Apr 24, 2023

Conversation

meretp
Copy link
Collaborator

@meretp meretp commented Apr 24, 2023

fixes #611

@meretp
[issue-611] set list like fields to empty lists if tags are empty
343baf1 
Signed-off-by: Meret Behrens <meret.behrens@tngtech.com>
@meretp
[issue-611] use list helper methods for creators to raise an error if…
3094f04 
… no creators provided

Signed-off-by: Meret Behrens <meret.behrens@tngtech.com>
@meretp
[issue-611] fix logging
1453613 
Signed-off-by: Meret Behrens <meret.behrens@tngtech.com>
armintaenzertng
armintaenzertng approved these changes Apr 24, 2023
View reviewed changes
Copy link
Collaborator

@armintaenzertng armintaenzertng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix! :)

@meretp meretp merged commit f0f41bc into spdx:main Apr 24, 2023
@meretp meretp deleted the issue_611_fix_xml_parser branch April 25, 2023 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@armintaenzertng armintaenzertng armintaenzertng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

XML Parser fails for empty tags
2 participants
@meretp @armintaenzertng