Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[issue_592] add top-level package #595

Merged
merged 1 commit into from
Apr 19, 2023

Conversation

meretp
Copy link
Collaborator

@meretp meretp commented Apr 19, 2023

This PR adds the packagee spdx_tools at top-level. With this the subpackages spdx and common are bundled under the package spdx_tools when installing the tools. We descided to use this structure to be able to include the spdx3 package next to the spdx package which is currently prototyped and will be added once SPDX 3.0 is published.

I will also update the migration guide according to the changed imports.

As this is a rather big refactoring please look at it carefully and tell me if I missed to adapt anything.

fixes #592

@meretp meretp changed the title [issue_592] add top-level module [issue_592] add top-level package Apr 19, 2023
Signed-off-by: Meret Behrens <meret.behrens@tngtech.com>
@meretp meretp force-pushed the issue_592_fix_installation_as_package branch from ad58479 to 7c5850e Compare April 19, 2023 07:22
Copy link
Collaborator

@armintaenzertng armintaenzertng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, lgtm

@meretp meretp merged commit b35941f into spdx:main Apr 19, 2023
@meretp meretp deleted the issue_592_fix_installation_as_package branch April 25, 2023 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

src/common should be installed inside package
2 participants